Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys Whatever the point of this "biodone_vfs" global function...



details:   https://anonhg.NetBSD.org/src/rev/ebff7b4221c4
branches:  trunk
changeset: 342850:ebff7b4221c4
user:      dholland <dholland%NetBSD.org@localhost>
date:      Mon Jan 11 01:22:36 2016 +0000

description:
Whatever the point of this "biodone_vfs" global function pointer is
(something rumpity?) declare it properly in a header file instead of
in secret where its types can diverge.

diffstat:

 sys/kern/vfs_bio.c |  5 ++---
 sys/sys/buf.h      |  4 +++-
 2 files changed, 5 insertions(+), 4 deletions(-)

diffs (44 lines):

diff -r 32f85b7d54a5 -r ebff7b4221c4 sys/kern/vfs_bio.c
--- a/sys/kern/vfs_bio.c        Mon Jan 11 01:08:09 2016 +0000
+++ b/sys/kern/vfs_bio.c        Mon Jan 11 01:22:36 2016 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: vfs_bio.c,v 1.257 2016/01/01 18:58:58 martin Exp $     */
+/*     $NetBSD: vfs_bio.c,v 1.258 2016/01/11 01:22:36 dholland Exp $   */
 
 /*-
  * Copyright (c) 2007, 2008, 2009 The NetBSD Foundation, Inc.
@@ -123,7 +123,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: vfs_bio.c,v 1.257 2016/01/01 18:58:58 martin Exp $");
+__KERNEL_RCSID(0, "$NetBSD: vfs_bio.c,v 1.258 2016/01/11 01:22:36 dholland Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_bufcache.h"
@@ -444,7 +444,6 @@
        struct bqueue *dp;
        int use_std;
        u_int i;
-       extern void (*biodone_vfs)(buf_t *);
 
        biodone_vfs = biodone;
 
diff -r 32f85b7d54a5 -r ebff7b4221c4 sys/sys/buf.h
--- a/sys/sys/buf.h     Mon Jan 11 01:08:09 2016 +0000
+++ b/sys/sys/buf.h     Mon Jan 11 01:22:36 2016 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: buf.h,v 1.123 2016/01/11 01:08:09 dholland Exp $ */
+/*     $NetBSD: buf.h,v 1.124 2016/01/11 01:22:36 dholland Exp $ */
 
 /*-
  * Copyright (c) 1999, 2000, 2007, 2008 The NetBSD Foundation, Inc.
@@ -88,6 +88,8 @@
 extern kmutex_t bufcache_lock;
 extern kmutex_t buffer_lock;
 
+extern void (*biodone_vfs)(buf_t *);
+
 /*
  * The buffer header describes an I/O operation in the kernel.
  *



Home | Main Index | Thread Index | Old Index