Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/if_ndis Uninitialized var, found by brainy. FreeBSD ...



details:   https://anonhg.NetBSD.org/src/rev/61bb67cd5021
branches:  trunk
changeset: 347122:61bb67cd5021
user:      maxv <maxv%NetBSD.org@localhost>
date:      Mon Aug 15 08:40:23 2016 +0000

description:
Uninitialized var, found by brainy. FreeBSD fixed it this way four years
ago. I haven't tested this change, but it is rather obvious, as the FreeBSD
commit indicates, that sc->ndis_io_rid should be used instead.

diffstat:

 sys/dev/if_ndis/if_ndis_pccard.c |  4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diffs (21 lines):

diff -r afcef371e2ed -r 61bb67cd5021 sys/dev/if_ndis/if_ndis_pccard.c
--- a/sys/dev/if_ndis/if_ndis_pccard.c  Mon Aug 15 08:24:05 2016 +0000
+++ b/sys/dev/if_ndis/if_ndis_pccard.c  Mon Aug 15 08:40:23 2016 +0000
@@ -31,7 +31,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_ndis_pccard.c,v 1.4 2009/03/14 15:36:18 dsl Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_ndis_pccard.c,v 1.5 2016/08/15 08:40:23 maxv Exp $");
 #ifdef __FreeBSD__
 __FBSDID("$FreeBSD: src/sys/dev/if_ndis/if_ndis_pccard.c,v 1.6.2.3 2005/03/31 04:24:36 wpaul Exp $");
 #endif
@@ -209,7 +209,7 @@
                goto fail;
        }
        sc->ndis_rescnt++;
-       resource_list_add(&sc->ndis_rl, SYS_RES_IOPORT, rid,
+       resource_list_add(&sc->ndis_rl, SYS_RES_IOPORT, sc->ndis_io_rid,
            rman_get_start(sc->ndis_res_io), rman_get_end(sc->ndis_res_io),
            rman_get_size(sc->ndis_res_io));
 



Home | Main Index | Thread Index | Old Index