Source-Changes-HG archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
[src/trunk]: src/sys/arch/evbarm/odroid Revert my previous change -- it break...
details: https://anonhg.NetBSD.org/src/rev/f86e410dd6d3
branches: trunk
changeset: 341867:f86e410dd6d3
user: marty <marty%NetBSD.org@localhost>
date: Thu Nov 26 21:27:31 2015 +0000
description:
Revert my previous change -- it breaks other odroid devices
diffstat:
sys/arch/evbarm/odroid/odroid_machdep.c | 79 +++++++++++++++-----------------
sys/arch/evbarm/odroid/odroid_start.S | 34 ++++++-------
sys/arch/evbarm/odroid/platform.h | 26 ++++++++--
3 files changed, 72 insertions(+), 67 deletions(-)
diffs (truncated from 340 to 300 lines):
diff -r 36e35b6f1f8f -r f86e410dd6d3 sys/arch/evbarm/odroid/odroid_machdep.c
--- a/sys/arch/evbarm/odroid/odroid_machdep.c Thu Nov 26 19:25:54 2015 +0000
+++ b/sys/arch/evbarm/odroid/odroid_machdep.c Thu Nov 26 21:27:31 2015 +0000
@@ -1,4 +1,8 @@
-/* $NetBSD: odroid_machdep.c,v 1.40 2015/11/25 04:04:13 marty Exp $ */
+<<<<<<< odroid_machdep.c
+/* $NetBSD: odroid_machdep.c,v 1.41 2015/11/26 21:27:31 marty Exp $ */
+=======
+/* $NetBSD: odroid_machdep.c,v 1.41 2015/11/26 21:27:31 marty Exp $ */
+>>>>>>> 1.7
/*
* Copyright (c) 2014 The NetBSD Foundation, Inc.
@@ -31,7 +35,11 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: odroid_machdep.c,v 1.40 2015/11/25 04:04:13 marty Exp $");
+<<<<<<< odroid_machdep.c
+__KERNEL_RCSID(0, "$NetBSD: odroid_machdep.c,v 1.41 2015/11/26 21:27:31 marty Exp $");
+=======
+__KERNEL_RCSID(0, "$NetBSD: odroid_machdep.c,v 1.41 2015/11/26 21:27:31 marty Exp $");
+>>>>>>> 1.7
#include "opt_evbarm_boardtype.h"
#include "opt_exynos.h"
@@ -128,6 +136,10 @@
#define CONMODE ((TTYDEF_CFLAG & ~(CSIZE | CSTOPB | PARENB | HUPCL)) | CS8) /* 8N1 */
#endif /* CONMODE */
+// __CTASSERT(EXYNOS_CORE_PBASE + EXYNOS_UART0_OFFSET <= CONADDR);
+// __CTASSERT(CONADDR <= EXYNOS_CORE_PBASE + EXYNOS_UART4_OFFSET);
+// __CTASSERT(CONADDR % EXYNOS_BLOCK_SIZE == 0);
+//static const bus_addr_t conaddr = CONADDR;
static const int conspeed = CONSPEED;
static const int conmode = CONMODE;
#endif /*defined(KGDB) || defined(SSCOM*CONSOLE) */
@@ -148,7 +160,7 @@
* argument and boot configure storage
*/
BootConfig bootconfig; /* for pmap's sake */
-char bootargs[MAX_BOOT_STRING]; /* copied string from uboot */
+char bootargs[MAX_BOOT_STRING] = ""; /* copied string from uboot */
char *boot_args = NULL; /* MI bootargs */
char *boot_file = NULL; /* MI bootfile */
uint8_t uboot_enaddr[ETHER_ADDR_LEN] = {};
@@ -177,9 +189,6 @@
static void exynos_extract_mac_adress(void);
void odroid_device_register(device_t self, void *aux);
void odroid_device_register_post_config(device_t self, void *aux);
-#ifdef MULTIPROCESSOR
-extern void exynos_cpu_hatch(struct cpu_info *ci);
-#endif
/*
@@ -237,21 +246,12 @@
#ifdef PMAP_NEED_ALLOC_POOLPAGE
static struct boot_physmem bp_highgig = {
- .bp_start = EXYNOS5_SDRAM_PBASE / NBPG,
.bp_pages = (KERNEL_VM_BASE - KERNEL_BASE) / NBPG,
- .bp_freelist = VM_FREELIST_DEFAULT,
+ .bp_freelist = VM_FREELIST_ISADMA,
.bp_flags = 0,
};
#endif
-#ifdef MULTIPROCESSOR
-void
-exynos_cpu_hatch(struct cpu_info *ci)
-{
- /* MJF: WRITE ME */
-}
-#endif
-
/*
* u_int initarm(...)
*
@@ -260,7 +260,6 @@
* - init the physical console
* - setting up page tables for the kernel
*/
-extern void xputc(int);
u_int
initarm(void *arg)
@@ -270,7 +269,6 @@
const psize_t ram_reserve = 0x200000;
psize_t ram_size;
-#if 0
/* allocate/map our basic memory mapping */
switch (EXYNOS_PRODUCT_FAMILY(exynos_soc_id)) {
#if defined(EXYNOS4)
@@ -290,24 +288,12 @@
panic("Unknown product family %llx",
EXYNOS_PRODUCT_FAMILY(exynos_soc_id));
}
-#else
- devmap = e5_devmap;
- rambase = EXYNOS5_SDRAM_PBASE;
-#endif
- xputc('<');
pmap_devmap_register(devmap);
- xputc('>');
-#if 0
/* bootstrap soc. uart_address is determined in odroid_start */
paddr_t uart_address = armreg_tpidruro_read();
exynos_bootstrap(EXYNOS_CORE_VBASE, EXYNOS_IOPHYSTOVIRT(uart_address));
-#else
- xputc('[');
- exynos_bootstrap(EXYNOS_CORE_VBASE,
- EXYNOS_CORE_VBASE + EXYNOS5_UART2_OFFSET);
- xputc(']');
-#endif
+
/* set up CPU / MMU / TLB functions */
if (set_cpufuncs())
panic("cpu not recognized!");
@@ -323,6 +309,7 @@
printf("\nuboot arg = %#"PRIxPTR", %#"PRIxPTR", %#"PRIxPTR", %#"PRIxPTR"\n",
uboot_args[0], uboot_args[1], uboot_args[2], uboot_args[3]);
printf("Exynos SoC ID %08x\n", exynos_soc_id);
+
printf("initarm: cbar=%#x\n", armreg_cbar_read());
#endif
@@ -437,19 +424,21 @@
consinit_called = true;
#if NSSCOM > 0
- bus_space_tag_t bst = &exynos_bs_tag;
bus_addr_t iobase = armreg_tpidruro_read();
+<<<<<<< odroid_machdep.c
+ bus_space_handle_t bsh = EXYNOS_IOPHYSTOVIRT(iobase);
u_int i;
-
/*
* No need to guess at the UART frequency since we can calculate it.
*/
- bus_space_handle_t bsh = EXYNOS_IOPHYSTOVIRT(iobase);
- uint32_t br0 = bus_space_read_4(bst, bsh, SSCOM_UBRDIV);
- uint32_t br1 = bus_space_read_4(bst, bsh, SSCOM_UFRACVAL);
- uint32_t freq = conspeed * (16 * (br0 + 1) + br1);
+ uint32_t freq = conspeed
+ * (16 * (bus_space_read_4(bst, bsh, SSCOM_UBRDIV) + 1)
+ + bus_space_read_4(bst, bsh, SSCOM_UFRACVAL));
freq = (freq + conspeed / 2) / 1000;
freq *= 1000;
+=======
+ size_t i;
+>>>>>>> 1.7
/* go trough all entries */
for (i = 0; i < num_exynos_uarts_entries; i++) {
@@ -457,16 +446,20 @@
if (exynos_uarts[i].iobase + EXYNOS_CORE_PBASE == iobase)
break;
}
+<<<<<<< odroid_machdep.c
KASSERT(i < num_exynos_uarts_entries);
-
+ printf("%s: attaching console @ %#"PRIxPTR" (%u HZ, %u bps)\n",
+ __func__, iobase, freq, conspeed);
if (sscom_cnattach(bst, exynos_core_bsh, &exynos_uarts[i],
conspeed, freq, conmode))
+=======
+ KASSERT(i < __arraycount(exynos_uarts));
+
+ if (sscom_cnattach(&exynos_bs_tag, exynos_core_bsh,
+ &exynos_uarts[i], conspeed, EXYNOS_UART_FREQ,
+ conmode))
+>>>>>>> 1.7
panic("Serial console can not be initialized");
- printf("%s: attached console @ %#"PRIxPTR" (%u HZ, %u bps)\n",
- __func__, iobase, freq, conspeed);
-#ifdef VERBOSE_INIT_ARM
- printf("Console initialized\n");
-#endif
#else
#error only serial console is supported
#if NUKBD > 0
diff -r 36e35b6f1f8f -r f86e410dd6d3 sys/arch/evbarm/odroid/odroid_start.S
--- a/sys/arch/evbarm/odroid/odroid_start.S Thu Nov 26 19:25:54 2015 +0000
+++ b/sys/arch/evbarm/odroid/odroid_start.S Thu Nov 26 21:27:31 2015 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: odroid_start.S,v 1.8 2015/11/25 04:04:13 marty Exp $ */
+/* $NetBSD: odroid_start.S,v 1.9 2015/11/26 21:27:31 marty Exp $ */
/*-
* Copyright (c) 2014 The NetBSD Foundation, Inc.
@@ -46,7 +46,7 @@
#include <evbarm/odroid/platform.h>
-RCSID("$NetBSD: odroid_start.S,v 1.8 2015/11/25 04:04:13 marty Exp $")
+RCSID("$NetBSD: odroid_start.S,v 1.9 2015/11/26 21:27:31 marty Exp $")
#if defined(VERBOSE_INIT_ARM)
@@ -90,9 +90,9 @@
cpsid if, #PSR_SVC32_MODE
/*
- * Save any arguments passed to us. If .start is not at
- * 0x80000000 but .text is, we can't directly use the address that
- * the linker gave us. Convert the virtual address to the
+ * Save any arguments passed to us. But since .start is not at
+ * 0x80000000 * but .text is, we can't directly use the address that
+ * the linker gave us directly. Convert the virtual address to the
* physical address by using KERNEL_BASE_VOFFSET.
*/
movw r4, #:lower16:uboot_args
@@ -112,9 +112,7 @@
movw r4, #:lower16:exynos_soc_id
movt r4, #:upper16:exynos_soc_id
-#if KERNEL_BASE_VOFFSET != 0
sub r4, r4, #KERNEL_BASE_VOFFSET
-#endif
str r0, [r4] // save soc_id
mov r5, r0 // save soc_id
@@ -154,7 +152,7 @@
*/
bl cortex_init
- XPUTC(#'@')
+ XPUTC(#'C')
/*
* Set up a preliminary mapping in the MMU to allow us to run
@@ -188,7 +186,6 @@
XPUTC2(#'Z')
#if defined(MULTIPROCESSOR)
- /* MJF: HA HA (There's no there here) */
#endif /* MULTIPROCESSOR */
XPUTC2(#13) /* CR */
@@ -211,23 +208,23 @@
.global _C_LABEL(exynos_uarts)
_C_LABEL(exynos_uarts):
.Lsscom_exynos4_table:
- .word 0
+ .word 0
.word EXYNOS4_UART0_OFFSET
- .word 1
+ .word 1
.word EXYNOS4_UART1_OFFSET
- .word 2
+ .word 2
.word EXYNOS4_UART2_OFFSET
- .word 3
+ .word 3
.word EXYNOS4_UART3_OFFSET
.Lsscom_exynos5_table:
- .word 0
+ .word 0
.word EXYNOS5_UART0_OFFSET
- .word 1
+ .word 1
.word EXYNOS5_UART1_OFFSET
- .word 2
+ .word 2
.word EXYNOS5_UART2_OFFSET
- .word 3
+ .word 3
.word EXYNOS5_UART3_OFFSET
@@ -271,7 +268,7 @@
bx lr
#endif
-#include <arm/cortex/cortex_init.S>
+#include <arm/cortex/a9_mpsubr.S>
#if EXYNOS_CORE_SIZE < EXYNOS4_CORE_SIZE
#error EXYNOS_CORE_SIZE smaller than EXYNOS4_CORE_SIZE
@@ -298,6 +295,7 @@
EXYNOS_CORE_SIZE / L1_S_SIZE,
L1_S_PROTO_armv7 | L1_S_APv7_KRW | L1_S_V6_XN)
+ /* Map EXYNOS CORE (so console will work) */
MMU_INIT(EXYNOS_CORE_PBASE, EXYNOS_CORE_PBASE,
EXYNOS_CORE_SIZE / L1_S_SIZE,
L1_S_PROTO_armv7 | L1_S_APv7_KRW | L1_S_V6_XN)
diff -r 36e35b6f1f8f -r f86e410dd6d3 sys/arch/evbarm/odroid/platform.h
--- a/sys/arch/evbarm/odroid/platform.h Thu Nov 26 19:25:54 2015 +0000
+++ b/sys/arch/evbarm/odroid/platform.h Thu Nov 26 21:27:31 2015 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: platform.h,v 1.4 2015/11/25 04:04:13 marty Exp $ */
+/* $NetBSD: platform.h,v 1.5 2015/11/26 21:27:31 marty Exp $ */
/*-
* Copyright (c) 2014 The NetBSD Foundation, Inc.
Home |
Main Index |
Thread Index |
Old Index