Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/tests/games Split each test into its own test case.



details:   https://anonhg.NetBSD.org/src/rev/cc080ba1e39a
branches:  trunk
changeset: 346117:cc080ba1e39a
user:      pgoyette <pgoyette%NetBSD.org@localhost>
date:      Mon Jun 27 05:08:18 2016 +0000

description:
Split each test into its own test case.

For test case loop2, where there are multiple prime factors greater
than 65535, skip the test if the program was not built with crypto
support.  We need crypto/openssl for large factors.

Should address PR bin/23663

diffstat:

 tests/games/t_factor.sh |  43 +++++++++++++++++++++++++++++++++----------
 1 files changed, 33 insertions(+), 10 deletions(-)

diffs (71 lines):

diff -r 5e43d66b1b6b -r cc080ba1e39a tests/games/t_factor.sh
--- a/tests/games/t_factor.sh   Mon Jun 27 01:46:04 2016 +0000
+++ b/tests/games/t_factor.sh   Mon Jun 27 05:08:18 2016 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: t_factor.sh,v 1.7 2010/11/19 12:31:36 pgoyette Exp $
+# $NetBSD: t_factor.sh,v 1.8 2016/06/27 05:08:18 pgoyette Exp $
 #
 # Copyright (c) 2007, 2008, 2009 The NetBSD Foundation, Inc.
 # All rights reserved.
@@ -30,29 +30,52 @@
        atf_check -s eq:0 -o file:expout -e empty /usr/games/factor ${1}
 }
 
-atf_test_case overflow
-overflow_head() {
+atf_test_case overflow1
+overflow1_head() {
        atf_set "descr" "Tests for overflow conditions"
        atf_set "require.progs" "/usr/games/factor"
 }
-overflow_body() {
+overflow1_body() {
        expect '8675309' '8675309: 8675309'
+}
+
+atf_test_case overflow2
+overflow2_head() {
+       atf_set "descr" "Tests for overflow conditions"
+       atf_set "require.progs" "/usr/games/factor"
+}
+overflow2_body() {
        expect '6172538568' '6172538568: 2 2 2 3 7 17 2161253'
 }
 
-atf_test_case loop
-loop_head() {
+atf_test_case loop1
+loop1_head() {
        atf_set "descr" "Tests some cases that once locked the program" \
                        "in an infinite loop"
        atf_set "require.progs" "/usr/games/factor"
 }
-loop_body() {
-       expect '99999999999991' '99999999999991: 7 13 769231 1428571'
+loop1_body() {
        expect '2147483647111311' '2147483647111311: 3 3 3 131 607148331103'
 }
 
+atf_test_case loop2
+loop2_head() {
+       atf_set "descr" "Tests some cases that once locked the program" \
+                       "in an infinite loop"
+       atf_set "require.progs" "/usr/games/factor"
+}
+loop2_body() {
+       ncrypt=$( ldd /usr/games/factor | grep -c -- -lcrypt )
+       if [ $ncrypt -eq 0 ] ; then 
+               atf_skip "crypto needed for huge non-prime factors - PR bin/23663"
+       fi
+       expect '99999999999991' '99999999999991: 7 13 769231 1428571' ExFail
+}
+
 atf_init_test_cases()
 {
-       atf_add_test_case overflow
-       atf_add_test_case loop
+       atf_add_test_case overflow1
+       atf_add_test_case overflow2
+       atf_add_test_case loop1
+       atf_add_test_case loop2
 }



Home | Main Index | Thread Index | Old Index