Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/arch PR 51200 gets in libsa considered harmful: use kgets



details:   https://anonhg.NetBSD.org/src/rev/bc7921c52b39
branches:  trunk
changeset: 345852:bc7921c52b39
user:      dholland <dholland%NetBSD.org@localhost>
date:      Sat Jun 11 06:35:00 2016 +0000

description:
PR 51200 gets in libsa considered harmful: use kgets

diffstat:

 sys/arch/next68k/stand/boot/boot.c  |  4 ++--
 sys/arch/ofppc/stand/ofwboot/boot.c |  4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diffs (36 lines):

diff -r bb8e94e3fbb1 -r bc7921c52b39 sys/arch/next68k/stand/boot/boot.c
--- a/sys/arch/next68k/stand/boot/boot.c        Sat Jun 11 06:24:36 2016 +0000
+++ b/sys/arch/next68k/stand/boot/boot.c        Sat Jun 11 06:35:00 2016 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: boot.c,v 1.11 2014/03/25 19:43:48 christos Exp $       */
+/*     $NetBSD: boot.c,v 1.12 2016/06/11 06:35:00 dholland Exp $       */
 /*
  * Copyright (c) 1994 Rolf Grossmann
  * All rights reserved.
@@ -122,7 +122,7 @@
 
                printf("load of %s: %s\n", kernel, strerror(errno));
                printf("boot: ");
-               gets(kernel);
+               kgets(kernel, sizeof(kernel));
                if (kernel[0] == '\0')
                        return 0;
 
diff -r bb8e94e3fbb1 -r bc7921c52b39 sys/arch/ofppc/stand/ofwboot/boot.c
--- a/sys/arch/ofppc/stand/ofwboot/boot.c       Sat Jun 11 06:24:36 2016 +0000
+++ b/sys/arch/ofppc/stand/ofwboot/boot.c       Sat Jun 11 06:35:00 2016 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: boot.c,v 1.23 2011/01/22 19:19:21 joerg Exp $  */
+/*     $NetBSD: boot.c,v 1.24 2016/06/11 06:35:38 dholland Exp $       */
 
 /*-
  * Copyright (c) 1997 The NetBSD Foundation, Inc.
@@ -230,7 +230,7 @@
 
                if (boothowto & RB_ASKNAME) {
                        printf("Boot: ");
-                       gets(bootline);
+                       kgets(bootline, sizeof(bootline));
                        parseargs(bootline, &boothowto);
                }
 



Home | Main Index | Thread Index | Old Index