Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/iscsi Use value *before* freeing it. Found by brainy...



details:   https://anonhg.NetBSD.org/src/rev/9a38594ed65f
branches:  trunk
changeset: 340615:9a38594ed65f
user:      dholland <dholland%NetBSD.org@localhost>
date:      Sat Sep 19 18:32:42 2015 +0000

description:
Use value *before* freeing it. Found by brainy, reported by maxv.

diffstat:

 sys/dev/iscsi/iscsi_ioctl.c |  4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diffs (20 lines):

diff -r 3eb705c67fe6 -r 9a38594ed65f sys/dev/iscsi/iscsi_ioctl.c
--- a/sys/dev/iscsi/iscsi_ioctl.c       Sat Sep 19 18:31:41 2015 +0000
+++ b/sys/dev/iscsi/iscsi_ioctl.c       Sat Sep 19 18:32:42 2015 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: iscsi_ioctl.c,v 1.12 2015/05/30 20:09:47 joerg Exp $   */
+/*     $NetBSD: iscsi_ioctl.c,v 1.13 2015/09/19 18:32:42 dholland Exp $        */
 
 /*-
  * Copyright (c) 2004,2005,2006,2011 The NetBSD Foundation, Inc.
@@ -1539,9 +1539,9 @@
                                        free(sess->target_list, M_TEMP);
                                /* notify event handlers of session shutdown */
                                add_event(ISCSI_SESSION_TERMINATED, sess->id, 0, status);
+                               DEB(1, ("Cleanup: session ended %d\n", sess->id));
                                free(sess, M_DEVBUF);
 
-                               DEB(1, ("Cleanup: session ended %d\n", sess->id));
                                s = splbio();
                        }
                        splx(s);



Home | Main Index | Thread Index | Old Index