Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/ic Another locking fix in slhci_roothub_ctrl



details:   https://anonhg.NetBSD.org/src/rev/be9c57b5499a
branches:  trunk
changeset: 345241:be9c57b5499a
user:      skrll <skrll%NetBSD.org@localhost>
date:      Sat May 14 08:52:20 2016 +0000

description:
Another locking fix in slhci_roothub_ctrl

diffstat:

 sys/dev/ic/sl811hs.c |  10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diffs (32 lines):

diff -r 185ba14b5017 -r be9c57b5499a sys/dev/ic/sl811hs.c
--- a/sys/dev/ic/sl811hs.c      Sat May 14 08:49:16 2016 +0000
+++ b/sys/dev/ic/sl811hs.c      Sat May 14 08:52:20 2016 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: sl811hs.c,v 1.68 2016/05/12 18:57:38 skrll Exp $       */
+/*     $NetBSD: sl811hs.c,v 1.69 2016/05/14 08:52:20 skrll Exp $       */
 
 /*
  * Not (c) 2007 Matthew Orgass
@@ -68,7 +68,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: sl811hs.c,v 1.68 2016/05/12 18:57:38 skrll Exp $");
+__KERNEL_RCSID(0, "$NetBSD: sl811hs.c,v 1.69 2016/05/14 08:52:20 skrll Exp $");
 
 #include "opt_slhci.h"
 
@@ -3162,9 +3162,11 @@
        /* Write Requests */
        case UR_CLEAR_FEATURE:
                if (type == UT_WRITE_CLASS_OTHER) {
-                       if (index == 1 /* Port */)
+                       if (index == 1 /* Port */) {
+                               mutex_enter(&sc->sc_intr_lock);
                                error = slhci_clear_feature(sc, value);
-                       else
+                               mutex_exit(&sc->sc_intr_lock);
+                       } else
                                DLOG(D_ROOT, "Clear Port Feature "
                                    "index = %#.4x", index, 0,0,0);
                }



Home | Main Index | Thread Index | Old Index