Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/external/gpl3/binutils/dist/bfd Revert. For whatever reasons...



details:   https://anonhg.NetBSD.org/src/rev/c6697265481f
branches:  trunk
changeset: 344961:c6697265481f
user:      joerg <joerg%NetBSD.org@localhost>
date:      Fri Apr 29 16:25:55 2016 +0000

description:
Revert. For whatever reasons, the ELF visibility attributes are not
meant to be a useful indicator of what an object expects, so for linking
against a protected symbol, it must be declared as normal.

diffstat:

 external/gpl3/binutils/dist/bfd/elflink.c |  5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diffs (32 lines):

diff -r 66311fcb2e41 -r c6697265481f external/gpl3/binutils/dist/bfd/elflink.c
--- a/external/gpl3/binutils/dist/bfd/elflink.c Fri Apr 29 16:08:09 2016 +0000
+++ b/external/gpl3/binutils/dist/bfd/elflink.c Fri Apr 29 16:25:55 2016 +0000
@@ -1252,7 +1252,6 @@
      definition from a dynamic object.  */
   if (newdyn
       && ELF_ST_VISIBILITY (h->other) != STV_DEFAULT
-      && ELF_ST_VISIBILITY (h->other) != STV_PROTECTED
       && !bfd_is_und_section (sec))
     {
       *skip = TRUE;
@@ -1270,7 +1269,6 @@
     }
   else if (!newdyn
           && ELF_ST_VISIBILITY (sym->st_other) != STV_DEFAULT
-          && ELF_ST_VISIBILITY (sym->st_other) != STV_PROTECTED
           && h->def_dynamic)
     {
       /* If the new symbol with non-default visibility comes from a
@@ -9337,11 +9335,10 @@
       && h->def_dynamic)
     sym.st_size = 0;
 
-  /* If a non-weak symbol with non-public visibility is not defined
+  /* If a non-weak symbol with non-default visibility is not defined
      locally, it is a fatal error.  */
   if (!bfd_link_relocatable (flinfo->info)
       && ELF_ST_VISIBILITY (sym.st_other) != STV_DEFAULT
-      && ELF_ST_VISIBILITY (sym.st_other) != STV_PROTECTED
       && ELF_ST_BIND (sym.st_info) != STB_WEAK
       && h->root.type == bfd_link_hash_undefined
       && !h->def_regular)



Home | Main Index | Thread Index | Old Index