Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/net Remove out-dated comments and unnecessary splsoftnet...



details:   https://anonhg.NetBSD.org/src/rev/ebf6a3a5acec
branches:  trunk
changeset: 344680:ebf6a3a5acec
user:      ozaki-r <ozaki-r%NetBSD.org@localhost>
date:      Mon Apr 11 08:26:33 2016 +0000

description:
Remove out-dated comments and unnecessary splsoftnet for pool_{get,put}

diffstat:

 sys/net/route.c |  10 ++--------
 1 files changed, 2 insertions(+), 8 deletions(-)

diffs (60 lines):

diff -r 885c23546aed -r ebf6a3a5acec sys/net/route.c
--- a/sys/net/route.c   Mon Apr 11 06:49:11 2016 +0000
+++ b/sys/net/route.c   Mon Apr 11 08:26:33 2016 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: route.c,v 1.160 2016/04/07 04:04:47 christos Exp $     */
+/*     $NetBSD: route.c,v 1.161 2016/04/11 08:26:33 ozaki-r Exp $      */
 
 /*-
  * Copyright (c) 1998, 2008 The NetBSD Foundation, Inc.
@@ -96,7 +96,7 @@
 #endif
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: route.c,v 1.160 2016/04/07 04:04:47 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: route.c,v 1.161 2016/04/11 08:26:33 ozaki-r Exp $");
 
 #include <sys/param.h>
 #ifdef RTFLUSH_DEBUG
@@ -796,7 +796,6 @@
                if (info->rti_ifa == NULL && (error = rt_getifa(info)))
                        senderr(error);
                ifa = info->rti_ifa;
-               /* Already at splsoftnet() so pool_get/pool_put are safe */
                rt = pool_get(&rtentry_pool, PR_NOWAIT);
                if (rt == NULL)
                        senderr(ENOBUFS);
@@ -1196,7 +1195,6 @@
                if (destroy)
                        (*r->rtt_func)(r->rtt_rt, r);
                rtfree(r->rtt_rt);
-               /* we are already at splsoftnet */
                pool_put(&rttimer_pool, r);
                if (rtq->rtq_count > 0)
                        rtq->rtq_count--;
@@ -1240,7 +1238,6 @@
                else
                        printf("rt_timer_remove_all: rtq_count reached 0\n");
                rtfree(r->rtt_rt);
-               /* we are already at splsoftnet */
                pool_put(&rttimer_pool, r);
        }
 }
@@ -1251,7 +1248,6 @@
        struct rttimer_queue *queue)
 {
        struct rttimer *r;
-       int s;
 
        KASSERT(func != NULL);
        /*
@@ -1271,9 +1267,7 @@
                        printf("rt_timer_add: rtq_count reached 0\n");
                rtfree(r->rtt_rt);
        } else {
-               s = splsoftnet();
                r = pool_get(&rttimer_pool, PR_NOWAIT);
-               splx(s);
                if (r == NULL)
                        return ENOBUFS;
        }



Home | Main Index | Thread Index | Old Index