[src/trunk]: src/sys/dev/usb Improve debug

[skrll <skrll%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/c3c02073a0f1
branches:  trunk
changeset: 336432:c3c02073a0f1
user:      skrll <skrll%NetBSD.org@localhost>
date:      Sun Mar 01 08:03:35 2015 +0000

description:
Improve debug

diffstat:

 sys/dev/usb/ehci.c |  14 +++++++++++---
 1 files changed, 11 insertions(+), 3 deletions(-)

diffs (50 lines):

diff -r 6fd8a10a46bd -r c3c02073a0f1 sys/dev/usb/ehci.c
--- a/sys/dev/usb/ehci.c        Sun Mar 01 08:00:57 2015 +0000
+++ b/sys/dev/usb/ehci.c        Sun Mar 01 08:03:35 2015 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ehci.c,v 1.236 2015/03/01 08:00:57 skrll Exp $ */
+/*     $NetBSD: ehci.c,v 1.237 2015/03/01 08:03:35 skrll Exp $ */
 
 /*
  * Copyright (c) 2004-2012 The NetBSD Foundation, Inc.
@@ -53,7 +53,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ehci.c,v 1.236 2015/03/01 08:00:57 skrll Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ehci.c,v 1.237 2015/03/01 08:03:35 skrll Exp $");
 
 #include "ohci.h"
 #include "uhci.h"
@@ -562,7 +562,9 @@
        usb_syncmem(&sqh->dma, sqh->offs, sizeof(sqh->qh),
            BUS_DMASYNC_PREWRITE | BUS_DMASYNC_PREREAD);
 #ifdef EHCI_DEBUG
+       USBHIST_LOGN(ehcidebug, 5, "--- dump start ---", 0, 0, 0, 0);
        ehci_dump_sqh(sqh);
+       USBHIST_LOGN(ehcidebug, 5, "--- dump end ---", 0, 0, 0, 0);
 #endif
 
        /* Point to async list */
@@ -889,6 +891,12 @@
                }
                USBHIST_LOGN(ehcidebug, 10, "ex=%p std=%p still active",
                    ex, ex->sqtdstart, 0, 0);
+#ifdef EHCI_DEBUG
+               USBHIST_LOGN(ehcidebug, 5, "--- still active start ---", 0, 0, 0, 0);
+               ehci_dump_sqtds(ex->ex_sqtdstart);
+               USBHIST_LOGN(ehcidebug, 5, "--- still active end ---", 0, 0, 0, 0);
+#endif
+
                return;
        }
  done:
@@ -1585,7 +1593,7 @@
                    sqtd->offs + offsetof(ehci_qtd_t, qtd_next),
                    sizeof(sqtd->qtd), BUS_DMASYNC_PREREAD);
        }
-       if (sqtd)
+       if (!stop)
                USBHIST_LOG(ehcidebug,
                    "dump aborted, too many TDs", 0, 0, 0, 0);
 }