[src/trunk]: src/sys/dev/ic RealTek 8139C+ incorrectly identifies UDP checksu...

[uwe <uwe%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/4bfe7d65c8da
branches:  trunk
changeset: 333001:4bfe7d65c8da
user:      uwe <uwe%NetBSD.org@localhost>
date:      Tue Oct 14 00:56:48 2014 +0000

description:
RealTek 8139C+ incorrectly identifies UDP checksum 0xffff as bad.
Force software recalculation of UDP checksum if bad checksum is
reported by the hardware.

diffstat:

 sys/dev/ic/rtl8169.c |  20 +++++++++++++++-----
 1 files changed, 15 insertions(+), 5 deletions(-)

diffs (41 lines):

diff -r e68c79420d93 -r 4bfe7d65c8da sys/dev/ic/rtl8169.c
--- a/sys/dev/ic/rtl8169.c      Mon Oct 13 22:41:59 2014 +0000
+++ b/sys/dev/ic/rtl8169.c      Tue Oct 14 00:56:48 2014 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: rtl8169.c,v 1.141 2014/10/10 17:41:05 christos Exp $   */
+/*     $NetBSD: rtl8169.c,v 1.142 2014/10/14 00:56:48 uwe Exp $        */
 
 /*
  * Copyright (c) 1997, 1998-2003
@@ -33,7 +33,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: rtl8169.c,v 1.141 2014/10/10 17:41:05 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: rtl8169.c,v 1.142 2014/10/14 00:56:48 uwe Exp $");
 /* $FreeBSD: /repoman/r/ncvs/src/sys/dev/re/if_re.c,v 1.20 2004/04/11 20:34:08 ru Exp $ */
 
 /*
@@ -1311,9 +1311,19 @@
                                                    M_CSUM_TCP_UDP_BAD;
                                } else if (RE_UDPPKT(rxstat)) {
                                        m->m_pkthdr.csum_flags |= M_CSUM_UDPv4;
-                                       if (rxstat & RE_RDESC_STAT_UDPSUMBAD)
-                                               m->m_pkthdr.csum_flags |=
-                                                   M_CSUM_TCP_UDP_BAD;
+                                       if (rxstat & RE_RDESC_STAT_UDPSUMBAD) {
+                                               /*
+                                                * XXX: 8139C+ thinks UDP csum
+                                                * 0xFFFF is bad, force software
+                                                * calculation.
+                                                */
+                                               if (sc->sc_quirk & RTKQ_8139CPLUS)
+                                                       m->m_pkthdr.csum_flags
+                                                           &= ~M_CSUM_UDPv4;
+                                               else
+                                                       m->m_pkthdr.csum_flags
+                                                           |= M_CSUM_TCP_UDP_BAD;
+                                       }
                                }
                        }
                } else {