Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/usr.bin/progress Retry read() on EINTR. Fixes premature exi...



details:   https://anonhg.NetBSD.org/src/rev/a1917eb18bd4
branches:  trunk
changeset: 335610:a1917eb18bd4
user:      gson <gson%NetBSD.org@localhost>
date:      Sat Jan 17 10:57:51 2015 +0000

description:
Retry read() on EINTR.  Fixes premature exit of
</dev/random progress -e cat >/dev/null

diffstat:

 usr.bin/progress/progress.c |  12 +++++++++---
 1 files changed, 9 insertions(+), 3 deletions(-)

diffs (40 lines):

diff -r 92df0082417b -r a1917eb18bd4 usr.bin/progress/progress.c
--- a/usr.bin/progress/progress.c       Fri Jan 16 23:46:37 2015 +0000
+++ b/usr.bin/progress/progress.c       Sat Jan 17 10:57:51 2015 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: progress.c,v 1.20 2012/06/27 22:07:36 riastradh Exp $ */
+/*     $NetBSD: progress.c,v 1.21 2015/01/17 10:57:51 gson Exp $ */
 
 /*-
  * Copyright (c) 2003 The NetBSD Foundation, Inc.
@@ -31,7 +31,7 @@
 
 #include <sys/cdefs.h>
 #ifndef lint
-__RCSID("$NetBSD: progress.c,v 1.20 2012/06/27 22:07:36 riastradh Exp $");
+__RCSID("$NetBSD: progress.c,v 1.21 2015/01/17 10:57:51 gson Exp $");
 #endif                         /* not lint */
 
 #include <sys/types.h>
@@ -228,7 +228,12 @@
        signal(SIGPIPE, broken_pipe);
        progressmeter(-1);
 
-       while ((nr = read(fd, fb_buf, buffersize)) > 0)
+       while (1) {
+               do {
+                       nr = read(fd, fb_buf, buffersize);
+               } while (nr < 0 && errno == EINTR);
+               if (nr <= 0)
+                       break;
                for (off = 0; nr; nr -= nw, off += nw, bytes += nw)
                        if ((nw = write(outpipe[1], fb_buf + off,
                            (size_t) nr)) < 0) {
@@ -236,6 +241,7 @@
                                err(1, "writing %u bytes to output pipe",
                                                        (unsigned) nr);
                        }
+       }
        close(outpipe[1]);
 
        gzipstat = 0;



Home | Main Index | Thread Index | Old Index