Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/marvell sizeof doesn't evaluate the expression, so i...



details:   https://anonhg.NetBSD.org/src/rev/b049732357e6
branches:  trunk
changeset: 335532:b049732357e6
user:      joerg <joerg%NetBSD.org@localhost>
date:      Sun Jan 11 22:59:57 2015 +0000

description:
sizeof doesn't evaluate the expression, so increment of rxd doesn't
happen. Move it out.

diffstat:

 sys/dev/marvell/if_gfe.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (27 lines):

diff -r acb2d0f1e335 -r b049732357e6 sys/dev/marvell/if_gfe.c
--- a/sys/dev/marvell/if_gfe.c  Sun Jan 11 22:59:25 2015 +0000
+++ b/sys/dev/marvell/if_gfe.c  Sun Jan 11 22:59:57 2015 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_gfe.c,v 1.43 2014/09/21 17:00:35 christos Exp $     */
+/*     $NetBSD: if_gfe.c,v 1.44 2015/01/11 22:59:57 joerg Exp $        */
 
 /*
  * Copyright (c) 2002 Allegro Networks, Inc., Wasabi Systems, Inc.
@@ -42,7 +42,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_gfe.c,v 1.43 2014/09/21 17:00:35 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_gfe.c,v 1.44 2015/01/11 22:59:57 joerg Exp $");
 
 #include "opt_inet.h"
 
@@ -816,7 +816,7 @@
        ds = rxq->rxq_buf_mem.gdm_map->dm_segs;
        nxtaddr = rxq->rxq_desc_busaddr + sizeof(*rxd);
        for (idx = 0, rxd = rxq->rxq_descs; idx < GE_RXDESC_MAX;
-           idx++, nxtaddr += sizeof(*(++rxd))) {
+           idx++, rxd++, nxtaddr += sizeof(*rxd)) {
                rxd->ed_lencnt = htogt32(GE_RXBUF_SIZE << 16);
                rxd->ed_cmdsts = htogt32(RX_CMD_F|RX_CMD_L|RX_CMD_O|RX_CMD_EI);
                rxd->ed_bufptr = htogt32(ds->ds_addr + boff);



Home | Main Index | Thread Index | Old Index