Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/nick-nhusb]: src/sys/dev/usb Remove unnecessary splnet from upl_attach



details:   https://anonhg.NetBSD.org/src/rev/2b77fa2b58fc
branches:  nick-nhusb
changeset: 334655:2b77fa2b58fc
user:      skrll <skrll%NetBSD.org@localhost>
date:      Tue Sep 05 07:06:30 2017 +0000

description:
Remove unnecessary splnet from upl_attach

diffstat:

 sys/dev/usb/if_upl.c |  8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)

diffs (43 lines):

diff -r 0f683b5171b2 -r 2b77fa2b58fc sys/dev/usb/if_upl.c
--- a/sys/dev/usb/if_upl.c      Tue Sep 05 07:04:17 2017 +0000
+++ b/sys/dev/usb/if_upl.c      Tue Sep 05 07:06:30 2017 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_upl.c,v 1.47.4.16 2017/02/05 13:40:46 skrll Exp $   */
+/*     $NetBSD: if_upl.c,v 1.47.4.17 2017/09/05 07:06:30 skrll Exp $   */
 /*
  * Copyright (c) 2000 The NetBSD Foundation, Inc.
  * All rights reserved.
@@ -34,7 +34,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_upl.c,v 1.47.4.16 2017/02/05 13:40:46 skrll Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_upl.c,v 1.47.4.17 2017/09/05 07:06:30 skrll Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_inet.h"
@@ -220,7 +220,6 @@
        struct upl_softc *sc = device_private(self);
        struct usb_attach_arg *uaa = aux;
        char                    *devinfop;
-       int                     s;
        struct usbd_device *    dev = uaa->uaa_device;
        struct usbd_interface * iface;
        usbd_status             err;
@@ -285,8 +284,6 @@
                return;
        }
 
-       s = splnet();
-
        /* Initialize interface info.*/
        ifp = &sc->sc_if;
        ifp->if_softc = sc;
@@ -316,7 +313,6 @@
            RND_TYPE_NET, RND_FLAG_DEFAULT);
 
        sc->sc_attached = 1;
-       splx(s);
 
        usbd_add_drv_event(USB_EVENT_DRIVER_ATTACH, sc->sc_udev, sc->sc_dev);
 



Home | Main Index | Thread Index | Old Index