Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/nick-nhusb]: src/sys/dev/usb Fix the error handling in smsc_init_locked....



details:   https://anonhg.NetBSD.org/src/rev/dc0d9589a50c
branches:  nick-nhusb
changeset: 334542:dc0d9589a50c
user:      skrll <skrll%NetBSD.org@localhost>
date:      Sun Oct 16 11:18:30 2016 +0000

description:
Fix the error handling in smsc_init_locked.  Spotted by #2.

diffstat:

 sys/dev/usb/if_smsc.c |  6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diffs (21 lines):

diff -r 661a090221d7 -r dc0d9589a50c sys/dev/usb/if_smsc.c
--- a/sys/dev/usb/if_smsc.c     Wed Oct 12 14:40:03 2016 +0000
+++ b/sys/dev/usb/if_smsc.c     Sun Oct 16 11:18:30 2016 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_smsc.c,v 1.22.2.15 2016/10/09 09:36:09 skrll Exp $  */
+/*     $NetBSD: if_smsc.c,v 1.22.2.16 2016/10/16 11:18:30 skrll Exp $  */
 
 /*     $OpenBSD: if_smsc.c,v 1.4 2012/09/27 12:38:11 jsg Exp $ */
 /* $FreeBSD: src/sys/dev/usb/net/if_smsc.c,v 1.1 2012/08/15 04:03:55 gonzo Exp $ */
@@ -625,10 +625,8 @@
        return 0;
 
 fail3:
-       smsc_tx_list_free(sc);
+       smsc_rx_list_free(sc);
 fail2:
-       smsc_rx_list_free(sc);
-
        usbd_close_pipe(sc->sc_ep[SMSC_ENDPT_TX]);
 fail1:
        usbd_close_pipe(sc->sc_ep[SMSC_ENDPT_RX]);



Home | Main Index | Thread Index | Old Index