Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev Use broadcast after freeing a cache entry. A waiter...



details:   https://anonhg.NetBSD.org/src/rev/b0a50ff7095c
branches:  trunk
changeset: 329461:b0a50ff7095c
user:      hannken <hannken%NetBSD.org@localhost>
date:      Sun May 25 13:52:12 2014 +0000

description:
Use broadcast after freeing a cache entry.  A waiter may not
use a cache entry after wakeup leading to possible deadlock.

diffstat:

 sys/dev/fss.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (27 lines):

diff -r b2fd8cb28e0e -r b0a50ff7095c sys/dev/fss.c
--- a/sys/dev/fss.c     Sun May 25 13:51:25 2014 +0000
+++ b/sys/dev/fss.c     Sun May 25 13:52:12 2014 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: fss.c,v 1.88 2014/03/16 05:20:26 dholland Exp $        */
+/*     $NetBSD: fss.c,v 1.89 2014/05/25 13:52:12 hannken Exp $ */
 
 /*-
  * Copyright (c) 2003 The NetBSD Foundation, Inc.
@@ -36,7 +36,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: fss.c,v 1.88 2014/03/16 05:20:26 dholland Exp $");
+__KERNEL_RCSID(0, "$NetBSD: fss.c,v 1.89 2014/05/25 13:52:12 hannken Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -1154,7 +1154,7 @@
                                fss_error(sc, "write error on backing store");
 
                        scp->fc_type = FSS_CACHE_FREE;
-                       cv_signal(&sc->sc_cache_cv);
+                       cv_broadcast(&sc->sc_cache_cv);
                        break;
                }
 



Home | Main Index | Thread Index | Old Index