Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/usr.sbin/mtree Pass a file pointer to write data instead of ...



details:   https://anonhg.NetBSD.org/src/rev/674e99a9b219
branches:  trunk
changeset: 328923:674e99a9b219
user:      christos <christos%NetBSD.org@localhost>
date:      Thu Apr 24 17:22:41 2014 +0000

description:
Pass a file pointer to write data instead of writing to stdout.
No functional change.

diffstat:

 usr.sbin/mtree/create.c |  112 ++++++++++++++++++++++++-----------------------
 usr.sbin/mtree/extern.h |    6 +-
 usr.sbin/mtree/mtree.c  |    8 +-
 usr.sbin/mtree/spec.c   |   69 +++++++++++++++-------------
 4 files changed, 102 insertions(+), 93 deletions(-)

diffs (truncated from 539 to 300 lines):

diff -r de49b58d92dd -r 674e99a9b219 usr.sbin/mtree/create.c
--- a/usr.sbin/mtree/create.c   Thu Apr 24 14:57:37 2014 +0000
+++ b/usr.sbin/mtree/create.c   Thu Apr 24 17:22:41 2014 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: create.c,v 1.72 2013/10/17 17:22:59 christos Exp $     */
+/*     $NetBSD: create.c,v 1.73 2014/04/24 17:22:41 christos Exp $     */
 
 /*-
  * Copyright (c) 1989, 1993
@@ -38,7 +38,7 @@
 #if 0
 static char sccsid[] = "@(#)create.c   8.1 (Berkeley) 6/6/93";
 #else
-__RCSID("$NetBSD: create.c,v 1.72 2013/10/17 17:22:59 christos Exp $");
+__RCSID("$NetBSD: create.c,v 1.73 2014/04/24 17:22:41 christos Exp $");
 #endif
 #endif /* not lint */
 
@@ -91,13 +91,14 @@
 #endif
 
 static int     dcmp(const FTSENT *FTS_CONST *, const FTSENT *FTS_CONST *);
-static void    output(int, int *, const char *, ...)
-       __attribute__((__format__(__printf__, 3, 4)));
-static int     statd(FTS *, FTSENT *, uid_t *, gid_t *, mode_t *, u_long *);
-static void    statf(int, FTSENT *);
+static void    output(FILE *, int, int *, const char *, ...)
+    __printflike(4, 5);
+static int     statd(FILE *, FTS *, FTSENT *, uid_t *, gid_t *, mode_t *,
+    u_long *);
+static void    statf(FILE *, int, FTSENT *);
 
 void
-cwalk(void)
+cwalk(FILE *fp)
 {
        FTS *t;
        FTSENT *p;
@@ -121,7 +122,7 @@
        }
 
        if (!nflag)
-               printf(
+               fprintf(fp,
                    "#\t   user: %s\n#\tmachine: %s\n#\t   tree: %s\n"
                    "#\t   date: %s",
                    user, host, fullpath, ctime(&clocktime));
@@ -142,21 +143,21 @@
                switch(p->fts_info) {
                case FTS_D:
                        if (!bflag)
-                               printf("\n");
+                               fprintf(fp, "\n");
                        if (!nflag)
-                               printf("# %s\n", p->fts_path);
-                       statd(t, p, &uid, &gid, &mode, &flags);
-                       statf(indent, p);
+                               fprintf(fp, "# %s\n", p->fts_path);
+                       statd(fp, t, p, &uid, &gid, &mode, &flags);
+                       statf(fp, indent, p);
                        break;
                case FTS_DP:
                        if (p->fts_level > 0)
                                if (!nflag)
-                                       printf("%*s# %s\n", indent, "",
+                                       fprintf(fp, "%*s# %s\n", indent, "",
                                            p->fts_path);
                        if (p->fts_level > 0 || flavor == F_FREEBSD9) {
-                               printf("%*s..\n", indent, "");
+                               fprintf(fp, "%*s..\n", indent, "");
                                if (!bflag)
-                                       printf("\n");
+                                       fprintf(fp, "\n");
                        }
                        break;
                case FTS_DNR:
@@ -167,7 +168,7 @@
                        break;
                default:
                        if (!dflag)
-                               statf(indent, p);
+                               statf(fp, indent, p);
                        break;
 
                }
@@ -178,7 +179,7 @@
 }
 
 static void
-statf(int indent, FTSENT *p)
+statf(FILE *fp, int indent, FTSENT *p)
 {
        u_int32_t len, val;
        int fd, offset;
@@ -187,51 +188,54 @@
        char *digestbuf;
 #endif
 
-       offset = printf("%*s%s%s", indent, "",
+       offset = fprintf(fp, "%*s%s%s", indent, "",
            S_ISDIR(p->fts_statp->st_mode) ? "" : "    ", vispath(p->fts_name));
 
        if (offset > (INDENTNAMELEN + indent))
                offset = MAXLINELEN;
        else
-               offset += printf("%*s", (INDENTNAMELEN + indent) - offset, "");
+               offset += fprintf(fp, "%*s",
+                   (INDENTNAMELEN + indent) - offset, "");
 
        if (!S_ISREG(p->fts_statp->st_mode) && (flavor == F_NETBSD6 || !dflag))
-               output(indent, &offset, "type=%s",
+               output(fp, indent, &offset, "type=%s",
                    inotype(p->fts_statp->st_mode));
        if (keys & (F_UID | F_UNAME) && p->fts_statp->st_uid != uid) {
                if (keys & F_UNAME &&
                    (name = user_from_uid(p->fts_statp->st_uid, 1)) != NULL)
-                       output(indent, &offset, "uname=%s", name);
+                       output(fp, indent, &offset, "uname=%s", name);
                if (keys & F_UID || (keys & F_UNAME && name == NULL))
-                       output(indent, &offset, "uid=%u", p->fts_statp->st_uid);
+                       output(fp, indent, &offset, "uid=%u",
+                           p->fts_statp->st_uid);
        }
        if (keys & (F_GID | F_GNAME) && p->fts_statp->st_gid != gid) {
                if (keys & F_GNAME &&
                    (name = group_from_gid(p->fts_statp->st_gid, 1)) != NULL)
-                       output(indent, &offset, "gname=%s", name);
+                       output(fp, indent, &offset, "gname=%s", name);
                if (keys & F_GID || (keys & F_GNAME && name == NULL))
-                       output(indent, &offset, "gid=%u", p->fts_statp->st_gid);
+                       output(fp, indent, &offset, "gid=%u",
+                           p->fts_statp->st_gid);
        }
        if (keys & F_MODE && (p->fts_statp->st_mode & MBITS) != mode)
-               output(indent, &offset, "mode=%#o",
+               output(fp, indent, &offset, "mode=%#o",
                    p->fts_statp->st_mode & MBITS);
        if (keys & F_DEV &&
            (S_ISBLK(p->fts_statp->st_mode) || S_ISCHR(p->fts_statp->st_mode)))
-               output(indent, &offset, "device=%#jx",
+               output(fp, indent, &offset, "device=%#jx",
                    (uintmax_t)p->fts_statp->st_rdev);
        if (keys & F_NLINK && p->fts_statp->st_nlink != 1)
-               output(indent, &offset, "nlink=%u", p->fts_statp->st_nlink);
+               output(fp, indent, &offset, "nlink=%u", p->fts_statp->st_nlink);
        if (keys & F_SIZE &&
            (flavor == F_FREEBSD9 || S_ISREG(p->fts_statp->st_mode)))
-               output(indent, &offset, "size=%ju",
+               output(fp, indent, &offset, "size=%ju",
                    (uintmax_t)p->fts_statp->st_size);
        if (keys & F_TIME)
 #if defined(BSD4_4) && !defined(HAVE_NBTOOL_CONFIG_H)
-               output(indent, &offset, "time=%jd.%09ld",
+               output(fp, indent, &offset, "time=%jd.%09ld",
                    (intmax_t)p->fts_statp->st_mtimespec.tv_sec,
                    p->fts_statp->st_mtimespec.tv_nsec);
 #else
-               output(indent, &offset, "time=%jd.%09ld",
+               output(fp, indent, &offset, "time=%jd.%09ld",
                    (intmax_t)p->fts_statp->st_mtime, (long)0);
 #endif
        if (keys & F_CKSUM && S_ISREG(p->fts_statp->st_mode)) {
@@ -239,14 +243,14 @@
                    crc(fd, &val, &len))
                        mtree_err("%s: %s", p->fts_accpath, strerror(errno));
                close(fd);
-               output(indent, &offset, "cksum=%lu", (long)val);
+               output(fp, indent, &offset, "cksum=%lu", (long)val);
        }
 #ifndef NO_MD5
        if (keys & F_MD5 && S_ISREG(p->fts_statp->st_mode)) {
                if ((digestbuf = MD5File(p->fts_accpath, NULL)) == NULL)
                        mtree_err("%s: MD5File failed: %s", p->fts_accpath,
                            strerror(errno));
-               output(indent, &offset, "%s=%s", MD5KEY, digestbuf);
+               output(fp, indent, &offset, "%s=%s", MD5KEY, digestbuf);
                free(digestbuf);
        }
 #endif /* ! NO_MD5 */
@@ -255,7 +259,7 @@
                if ((digestbuf = RMD160File(p->fts_accpath, NULL)) == NULL)
                        mtree_err("%s: RMD160File failed: %s", p->fts_accpath,
                            strerror(errno));
-               output(indent, &offset, "%s=%s", RMD160KEY, digestbuf);
+               output(fp, indent, &offset, "%s=%s", RMD160KEY, digestbuf);
                free(digestbuf);
        }
 #endif /* ! NO_RMD160 */
@@ -264,7 +268,7 @@
                if ((digestbuf = SHA1File(p->fts_accpath, NULL)) == NULL)
                        mtree_err("%s: SHA1File failed: %s", p->fts_accpath,
                            strerror(errno));
-               output(indent, &offset, "%s=%s", SHA1KEY, digestbuf);
+               output(fp, indent, &offset, "%s=%s", SHA1KEY, digestbuf);
                free(digestbuf);
        }
 #endif /* ! NO_SHA1 */
@@ -273,7 +277,7 @@
                if ((digestbuf = SHA256_File(p->fts_accpath, NULL)) == NULL)
                        mtree_err("%s: SHA256_File failed: %s", p->fts_accpath,
                            strerror(errno));
-               output(indent, &offset, "%s=%s", SHA256KEY, digestbuf);
+               output(fp, indent, &offset, "%s=%s", SHA256KEY, digestbuf);
                free(digestbuf);
        }
 #ifdef SHA384_BLOCK_LENGTH
@@ -281,7 +285,7 @@
                if ((digestbuf = SHA384_File(p->fts_accpath, NULL)) == NULL)
                        mtree_err("%s: SHA384_File failed: %s", p->fts_accpath,
                            strerror(errno));
-               output(indent, &offset, "%s=%s", SHA384KEY, digestbuf);
+               output(fp, indent, &offset, "%s=%s", SHA384KEY, digestbuf);
                free(digestbuf);
        }
 #endif
@@ -289,18 +293,18 @@
                if ((digestbuf = SHA512_File(p->fts_accpath, NULL)) == NULL)
                        mtree_err("%s: SHA512_File failed: %s", p->fts_accpath,
                            strerror(errno));
-               output(indent, &offset, "%s=%s", SHA512KEY, digestbuf);
+               output(fp, indent, &offset, "%s=%s", SHA512KEY, digestbuf);
                free(digestbuf);
        }
 #endif /* ! NO_SHA2 */
        if (keys & F_SLINK &&
            (p->fts_info == FTS_SL || p->fts_info == FTS_SLNONE))
-               output(indent, &offset, "link=%s",
+               output(fp, indent, &offset, "link=%s",
                    vispath(rlink(p->fts_accpath)));
 #if HAVE_STRUCT_STAT_ST_FLAGS
        if (keys & F_FLAGS && p->fts_statp->st_flags != flags) {
                char *str = flags_to_string(p->fts_statp->st_flags, "none");
-               output(indent, &offset, "flags=%s", str);
+               output(fp, indent, &offset, "flags=%s", str);
                free(str);
        }
 #endif
@@ -324,8 +328,8 @@
 #define        MTREE_MAXS 16
 
 static int
-statd(FTS *t, FTSENT *parent, uid_t *puid, gid_t *pgid, mode_t *pmode,
-      u_long *pflags)
+statd(FILE *fp, FTS *t, FTSENT *parent, uid_t *puid, gid_t *pgid, mode_t *pmode,
+    u_long *pflags)
 {
        FTSENT *p;
        gid_t sgid;
@@ -398,33 +402,33 @@
            first) {
                first = 0;
                if (flavor != F_NETBSD6 && dflag)
-                       printf("/set type=dir");
+                       fprintf(fp, "/set type=dir");
                else
-                       printf("/set type=file");
+                       fprintf(fp, "/set type=file");
                if (keys & (F_UID | F_UNAME)) {
                        if (keys & F_UNAME &&
                            (name = user_from_uid(saveuid, 1)) != NULL)
-                               printf(" uname=%s", name);
+                               fprintf(fp, " uname=%s", name);
                        if (keys & F_UID || (keys & F_UNAME && name == NULL))
-                               printf(" uid=%lu", (u_long)saveuid);
+                               fprintf(fp, " uid=%lu", (u_long)saveuid);
                }
                if (keys & (F_GID | F_GNAME)) {
                        if (keys & F_GNAME &&
                            (name = group_from_gid(savegid, 1)) != NULL)
-                               printf(" gname=%s", name);
+                               fprintf(fp, " gname=%s", name);
                        if (keys & F_GID || (keys & F_GNAME && name == NULL))
-                               printf(" gid=%lu", (u_long)savegid);
+                               fprintf(fp, " gid=%lu", (u_long)savegid);
                }
                if (keys & F_MODE)
-                       printf(" mode=%#lo", (u_long)savemode);
+                       fprintf(fp, " mode=%#lo", (u_long)savemode);
                if (keys & F_NLINK)
-                       printf(" nlink=1");
+                       fprintf(fp, " nlink=1");
                if (keys & F_FLAGS) {
                        char *str = flags_to_string(saveflags, "none");
-                       printf(" flags=%s", str);
+                       fprintf(fp, " flags=%s", str);
                        free(str);
                }
-               printf("\n");
+               fprintf(fp, "\n");
                *puid = saveuid;
                *pgid = savegid;
                *pmode = savemode;
@@ -455,7 +459,7 @@
 }
 
 void
-output(int indent, int *offset, const char *fmt, ...)
+output(FILE *fp, int indent, int *offset, const char *fmt, ...)
 {
        va_list ap;



Home | Main Index | Thread Index | Old Index