Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/arch/atari/dev Make sure to acquire proc_lock mutex on c...



details:   https://anonhg.NetBSD.org/src/rev/b339486c71f8
branches:  trunk
changeset: 328217:b339486c71f8
user:      tsutsui <tsutsui%NetBSD.org@localhost>
date:      Sat Mar 29 16:46:19 2014 +0000

description:
Make sure to acquire proc_lock mutex on calling psignal(9) in EV_WAKEUP().

Without this, Xserver could cause panic on the DIAGNOSTIC kernel as x68k:
http://mail-index.netbsd.org/source-changes/2012/08/15/msg036632.html

diffstat:

 sys/arch/atari/dev/event_var.h |  7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diffs (22 lines):

diff -r caa6787ba81d -r b339486c71f8 sys/arch/atari/dev/event_var.h
--- a/sys/arch/atari/dev/event_var.h    Sat Mar 29 16:10:54 2014 +0000
+++ b/sys/arch/atari/dev/event_var.h    Sat Mar 29 16:46:19 2014 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: event_var.h,v 1.8 2009/03/14 14:45:56 dsl Exp $        */
+/*     $NetBSD: event_var.h,v 1.9 2014/03/29 16:46:19 tsutsui Exp $    */
 
 /*
  * Copyright (c) 1992, 1993
@@ -69,8 +69,11 @@
                (ev)->ev_wanted = 0; \
                wakeup((void *)(ev)); \
        } \
-       if ((ev)->ev_async) \
+       if ((ev)->ev_async) { \
+               mutex_enter(proc_lock); \
                psignal((ev)->ev_io, SIGIO); \
+               mutex_exit(proc_lock); \
+       } \
 }
 
 void   ev_init(struct evvar *);



Home | Main Index | Thread Index | Old Index