Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/games Add note cautioning against bothering with WARNS=6 unt...



details:   https://anonhg.NetBSD.org/src/rev/b114b0c72f6d
branches:  trunk
changeset: 327995:b114b0c72f6d
user:      dholland <dholland%NetBSD.org@localhost>
date:      Sun Mar 23 00:17:40 2014 +0000

description:
Add note cautioning against bothering with WARNS=6 until gcc improves
(or -Wconversion is removed from WARNS=6) as it produces loads of false
positives. The most entertaining of these that I've seen this afternoon:

games/hack/hack.apply.c:143:22: error: conversion to 'unsigned char:1' from 'int' may alter its value [-Werror=conversion]
   flags.move = multi = 0;
                      ^

diffstat:

 games/Makefile.inc |  5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diffs (17 lines):

diff -r f72550a3284b -r b114b0c72f6d games/Makefile.inc
--- a/games/Makefile.inc        Sun Mar 23 00:07:15 2014 +0000
+++ b/games/Makefile.inc        Sun Mar 23 00:17:40 2014 +0000
@@ -1,4 +1,4 @@
-#      $NetBSD: Makefile.inc,v 1.15 2012/06/19 05:46:08 dholland Exp $
+#      $NetBSD: Makefile.inc,v 1.16 2014/03/23 00:17:40 dholland Exp $
 #      @(#)Makefile.inc        8.1 (Berkeley) 5/31/93
 
 MKHIDEGAME?=   no
@@ -20,4 +20,7 @@
 BINMODE=       2555
 .endif
 .endif
+# Note: do not bother with WARNS=6 until -Wconversion is either
+# removed from WARNS=6 or rendered useful by improving gcc; as it is
+# (with gcc48) it produces buckets of drivel.
 WARNS?=                5



Home | Main Index | Thread Index | Old Index