Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/usb Initialize a variable earlier, so it is not used...



details:   https://anonhg.NetBSD.org/src/rev/4dd59301eecb
branches:  trunk
changeset: 326401:4dd59301eecb
user:      martin <martin%NetBSD.org@localhost>
date:      Tue Jan 28 13:43:33 2014 +0000

description:
Initialize a variable earlier, so it is not used unitialized in an
error path.

diffstat:

 sys/dev/usb/uvideo.c |  7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diffs (35 lines):

diff -r a9cffd2ee369 -r 4dd59301eecb sys/dev/usb/uvideo.c
--- a/sys/dev/usb/uvideo.c      Tue Jan 28 13:25:53 2014 +0000
+++ b/sys/dev/usb/uvideo.c      Tue Jan 28 13:43:33 2014 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: uvideo.c,v 1.39 2013/10/17 21:07:37 christos Exp $     */
+/*     $NetBSD: uvideo.c,v 1.40 2014/01/28 13:43:33 martin Exp $       */
 
 /*
  * Copyright (c) 2008 Patrick Mahoney
@@ -42,7 +42,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: uvideo.c,v 1.39 2013/10/17 21:07:37 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: uvideo.c,v 1.40 2014/01/28 13:43:33 martin Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_uvideo.h"
@@ -797,6 +797,8 @@
                return USBD_NORMAL_COMPLETION;
        }
 
+       i = 0;
+
        /* allocate space for units */
        sc->sc_nunits = nunits;
        sc->sc_unit = kmem_alloc(sizeof(*sc->sc_unit) * nunits, KM_SLEEP);
@@ -807,7 +809,6 @@
        memcpy(iter, &orig, sizeof(orig));
 
        /* iterate again, initializing the units */
-       i = 0;
        while ((desc = usb_desc_iter_next_non_interface(iter)) != NULL) {
                uvdesc = (const uvideo_descriptor_t *)desc;
 



Home | Main Index | Thread Index | Old Index