Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/usb On detach, print error message with aprint_error...



details:   https://anonhg.NetBSD.org/src/rev/dfffcc2c5d62
branches:  trunk
changeset: 324833:dfffcc2c5d62
user:      msaitoh <msaitoh%NetBSD.org@localhost>
date:      Tue Jul 24 03:58:36 2018 +0000

description:
On detach, print error message with aprint_error_dev() instead of printf().

diffstat:

 sys/dev/usb/usbdi_util.c |  10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)

diffs (38 lines):

diff -r 7e5f36f2a43b -r dfffcc2c5d62 sys/dev/usb/usbdi_util.c
--- a/sys/dev/usb/usbdi_util.c  Tue Jul 24 02:52:15 2018 +0000
+++ b/sys/dev/usb/usbdi_util.c  Tue Jul 24 03:58:36 2018 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: usbdi_util.c,v 1.70 2017/10/28 00:37:13 pgoyette Exp $ */
+/*     $NetBSD: usbdi_util.c,v 1.71 2018/07/24 03:58:36 msaitoh Exp $  */
 
 /*
  * Copyright (c) 1998, 2012 The NetBSD Foundation, Inc.
@@ -31,7 +31,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: usbdi_util.c,v 1.70 2017/10/28 00:37:13 pgoyette Exp $");
+__KERNEL_RCSID(0, "$NetBSD: usbdi_util.c,v 1.71 2018/07/24 03:58:36 msaitoh Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_usb.h"
@@ -558,8 +558,7 @@
 
        DPRINTFN(1, "waiting for dv %#jx", (uintptr_t)dv, 0, 0, 0);
        if (cv_timedwait(cv, lock, hz * 60))    // dv, PZERO, "usbdet", hz * 60
-               printf("usb_detach_wait: %s didn't detach\n",
-                       device_xname(dv));
+               aprint_error_dev(dv, "usb_detach_wait: didn't detach\n");
        DPRINTFN(1, "done", 0, 0, 0, 0);
 }
 
@@ -579,8 +578,7 @@
 
        DPRINTFN(1, "waiting for dv %#jx", (uintptr_t)dv, 0, 0, 0);
        if (tsleep(dv, PZERO, "usbdet", hz * 60)) /* XXXSMP ok */
-               printf("usb_detach_waitold: %s didn't detach\n",
-                       device_xname(dv));
+               aprint_error_dev(dv, "usb_detach_waitold: didn't detach\n");
        DPRINTFN(1, "done", 0, 0, 0, 0);
 }
 



Home | Main Index | Thread Index | Old Index