Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/mii - All of Marvell PHY's registers from addr 0x0 t...



details:   https://anonhg.NetBSD.org/src/rev/575edb4c9eb4
branches:  trunk
changeset: 319983:575edb4c9eb4
user:      msaitoh <msaitoh%NetBSD.org@localhost>
date:      Mon Jun 18 09:12:17 2018 +0000

description:
- All of Marvell PHY's registers from addr 0x0 to 0xf conforms IEEE 802.3
 specification, so those register definitions are not required. Use mii.h's
 definitions. Note that E1000_ER_PAR_DETECT_FAULT should be 0x0010 instead of
 0x0100(typo).
- Restore code for BMCR_ISO which was removed in makphy.c rev. 1.44
- Whitespace fix.

diffstat:

 sys/dev/mii/e1000phyreg.h |  141 +---------------------------------------------
 sys/dev/mii/makphy.c      |   46 ++++++++------
 2 files changed, 29 insertions(+), 158 deletions(-)

diffs (280 lines):

diff -r be7b4251d8c6 -r 575edb4c9eb4 sys/dev/mii/e1000phyreg.h
--- a/sys/dev/mii/e1000phyreg.h Mon Jun 18 09:11:03 2018 +0000
+++ b/sys/dev/mii/e1000phyreg.h Mon Jun 18 09:12:17 2018 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: e1000phyreg.h,v 1.1 2018/06/16 17:44:53 jdolecek Exp $ */
+/*     $NetBSD: e1000phyreg.h,v 1.2 2018/06/18 09:12:17 msaitoh Exp $  */
 /* $FreeBSD: head/sys/dev/mii/e1000phyreg.h 326022 2017-11-20 19:36:21Z pfg $ */
 /*-
  * Principal Author: Parag Patel
@@ -73,147 +73,12 @@
 
 #define E1000_MAX_REG_ADDRESS          0x1F
 
-#define E1000_CR                       0x00    /* control register */
-#define E1000_CR_SPEED_SELECT_MSB      0x0040
-#define E1000_CR_COLL_TEST_ENABLE      0x0080
-#define E1000_CR_FULL_DUPLEX           0x0100
-#define E1000_CR_RESTART_AUTO_NEG      0x0200
-#define E1000_CR_ISOLATE               0x0400
-#define E1000_CR_POWER_DOWN            0x0800
-#define E1000_CR_AUTO_NEG_ENABLE       0x1000
-#define E1000_CR_SPEED_SELECT_LSB      0x2000
-#define E1000_CR_LOOPBACK              0x4000
-#define E1000_CR_RESET                 0x8000
-
-#define E1000_CR_SPEED_1000            0x0040
-#define E1000_CR_SPEED_100             0x2000
-#define E1000_CR_SPEED_10              0x0000
-
-#define E1000_SR                       0x01    /* status register */
-#define E1000_SR_EXTENDED              0x0001
-#define E1000_SR_JABBER_DETECT         0x0002
-#define E1000_SR_LINK_STATUS           0x0004
-#define E1000_SR_AUTO_NEG              0x0008
-#define E1000_SR_REMOTE_FAULT          0x0010
-#define E1000_SR_AUTO_NEG_COMPLETE     0x0020
-#define E1000_SR_PREAMBLE_SUPPRESS     0x0040
-#define E1000_SR_EXTENDED_STATUS       0x0100
-#define E1000_SR_100T2                 0x0200
-#define E1000_SR_100T2_FD              0x0400
-#define E1000_SR_10T                   0x0800
-#define E1000_SR_10T_FD                        0x1000
-#define E1000_SR_100TX                 0x2000
-#define E1000_SR_100TX_FD              0x4000
-#define E1000_SR_100T4                 0x8000
-
-#define E1000_ID1                      0x02    /* ID register 1 */
-#define E1000_ID2                      0x03    /* ID register 2 */
-#define E1000_ID_88E1000               0x01410C50
-#define E1000_ID_88E1000S              0x01410C40
-#define E1000_ID_88E1011               0x01410C20
-#define E1000_ID_MASK                  0xFFFFFFF0
-
-#define E1000_AR                       0x04    /* autonegotiation advertise reg */
-#define E1000_AR_SELECTOR_FIELD                0x0001
-#define E1000_AR_10T                   0x0020
-#define E1000_AR_10T_FD                        0x0040
-#define E1000_AR_100TX                 0x0080
-#define E1000_AR_100TX_FD              0x0100
-#define E1000_AR_100T4                 0x0200
-#define E1000_AR_PAUSE                 0x0400
-#define E1000_AR_ASM_DIR               0x0800
-#define E1000_AR_REMOTE_FAULT          0x2000
-#define E1000_AR_NEXT_PAGE             0x8000
-#define E1000_AR_SPEED_MASK            0x01E0
-
-/* Autonegotiation register bits for fiber cards (Alaska Only!) */
-#define E1000_FA_1000X_FD              0x0020
-#define E1000_FA_1000X                 0x0040
-#define E1000_FA_SYM_PAUSE             0x0080
-#define E1000_FA_ASYM_PAUSE            0x0100
-#define E1000_FA_FAULT1                        0x1000
-#define E1000_FA_FAULT2                        0x2000
-#define E1000_FA_NEXT_PAGE             0x8000
-
-#define E1000_LPAR                     0x05    /* autoneg link partner abilities reg */
-#define E1000_LPAR_SELECTOR_FIELD      0x0001
-#define E1000_LPAR_10T                 0x0020
-#define E1000_LPAR_10T_FD              0x0040
-#define E1000_LPAR_100TX               0x0080
-#define E1000_LPAR_100TX_FD            0x0100
-#define E1000_LPAR_100T4               0x0200
-#define E1000_LPAR_PAUSE               0x0400
-#define E1000_LPAR_ASM_DIR             0x0800
-#define E1000_LPAR_REMOTE_FAULT                0x2000
-#define E1000_LPAR_ACKNOWLEDGE         0x4000
-#define E1000_LPAR_NEXT_PAGE           0x8000
-
-/* autoneg link partner ability register bits for fiber cards (Alaska Only!) */
-#define E1000_FPAR_1000X_FD            0x0020
-#define E1000_FPAR_1000X               0x0040
-#define E1000_FPAR_SYM_PAUSE           0x0080
-#define E1000_FPAR_ASYM_PAUSE          0x0100
-#define E1000_FPAR_FAULT1              0x1000
-#define E1000_FPAR_FAULT2              0x2000
-#define E1000_FPAR_ACK                 0x4000
-#define E1000_FPAR_NEXT_PAGE           0x8000
-
-#define E1000_ER                       0x06    /* autoneg expansion reg */
-#define E1000_ER_LP_NWAY               0x0001
-#define E1000_ER_PAGE_RXD              0x0002
-#define E1000_ER_NEXT_PAGE             0x0004
-#define E1000_ER_LP_NEXT_PAGE          0x0008
-#define E1000_ER_PAR_DETECT_FAULT      0x0100
-
-#define E1000_NPTX                     0x07    /* autoneg next page TX */
-#define E1000_NPTX_MSG_CODE_FIELD      0x0001
-#define E1000_NPTX_TOGGLE              0x0800
-#define E1000_NPTX_ACKNOWLDGE2         0x1000
-#define E1000_NPTX_MSG_PAGE            0x2000
-#define E1000_NPTX_NEXT_PAGE           0x8000
-
-#define E1000_RNPR                     0x08    /* autoneg link-partner (?) next page */
-#define E1000_RNPR_MSG_CODE_FIELD      0x0001
-#define E1000_RNPR_TOGGLE              0x0800
-#define E1000_RNPR_ACKNOWLDGE2         0x1000
-#define E1000_RNPR_MSG_PAGE            0x2000
-#define E1000_RNPR_ACKNOWLDGE          0x4000
-#define E1000_RNPR_NEXT_PAGE           0x8000
-
-#define E1000_1GCR                     0x09    /* 1000T (1G) control reg */
-#define E1000_1GCR_ASYM_PAUSE          0x0080
-#define E1000_1GCR_1000T               0x0100
-#define E1000_1GCR_1000T_FD            0x0200
-#define E1000_1GCR_REPEATER_DTE                0x0400
-#define E1000_1GCR_MS_VALUE            0x0800
-#define E1000_1GCR_MS_ENABLE           0x1000
-#define E1000_1GCR_TEST_MODE_NORMAL    0x0000
-#define E1000_1GCR_TEST_MODE_1         0x2000
-#define E1000_1GCR_TEST_MODE_2         0x4000
-#define E1000_1GCR_TEST_MODE_3         0x6000
-#define E1000_1GCR_TEST_MODE_4         0x8000
-#define E1000_1GCR_SPEED_MASK          0x0300
-
-#define E1000_1GSR                     0x0A    /* 1000T (1G) status reg */
-#define E1000_1GSR_IDLE_ERROR_CNT      0x0000
-#define E1000_1GSR_ASYM_PAUSE_DIR      0x0100
-#define E1000_1GSR_LP                  0x0400
-#define E1000_1GSR_LP_FD               0x0800
-#define E1000_1GSR_REMOTE_RX_STATUS    0x1000
-#define E1000_1GSR_LOCAL_RX_STATUS     0x2000
-#define E1000_1GSR_MS_CONFIG_RES       0x4000
-#define E1000_1GSR_MS_CONFIG_FAULT     0x8000
-
-#define E1000_ESR                      0x0F    /* IEEE extended status reg */
-#define E1000_ESR_1000T                        0x1000
-#define E1000_ESR_1000T_FD             0x2000
-#define E1000_ESR_1000X                        0x4000
-#define E1000_ESR_1000X_FD             0x8000
-
+#if 0 /* XXX What is this? */
 #define E1000_TX_POLARITY_MASK         0x0100
 #define E1000_TX_NORMAL_POLARITY       0
 
 #define E1000_AUTO_POLARITY_DISABLE    0x0010
+#endif
 
 #define E1000_SCR                      0x10    /* special control register */
 #define E1000_SCR_JABBER_DISABLE       0x0001
diff -r be7b4251d8c6 -r 575edb4c9eb4 sys/dev/mii/makphy.c
--- a/sys/dev/mii/makphy.c      Mon Jun 18 09:11:03 2018 +0000
+++ b/sys/dev/mii/makphy.c      Mon Jun 18 09:12:17 2018 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: makphy.c,v 1.44 2018/06/16 17:44:53 jdolecek Exp $     */
+/*     $NetBSD: makphy.c,v 1.45 2018/06/18 09:12:17 msaitoh Exp $      */
 /*     $OpenBSD: eephy.c,v 1.56 2015/03/14 03:38:48 jsg Exp $  */
 
 /*-
@@ -96,7 +96,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: makphy.c,v 1.44 2018/06/16 17:44:53 jdolecek Exp $");
+__KERNEL_RCSID(0, "$NetBSD: makphy.c,v 1.45 2018/06/18 09:12:17 msaitoh Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -286,14 +286,14 @@
 {
        int reg, i;
 
-       reg = PHY_READ(sc, E1000_CR);
-       reg |= E1000_CR_RESET;
-       PHY_WRITE(sc, E1000_CR, reg);
+       reg = PHY_READ(sc, MII_BMCR);
+       reg |= BMCR_RESET;
+       PHY_WRITE(sc, MII_BMCR, reg);
        
        for (i = 0; i < 500; i++) {
                DELAY(1);
-               reg = PHY_READ(sc, E1000_CR);
-               if (!(reg & E1000_CR_RESET))
+               reg = PHY_READ(sc, MII_BMCR);
+               if (!(reg & BMCR_RESET))
                        break;
        }
 
@@ -363,9 +363,9 @@
         * Disable autonegotiation, such that all capabilities get
         * advertised when it is switched back on.
         */
-       reg = PHY_READ(sc, E1000_CR);
-       reg &= ~E1000_CR_AUTO_NEG_ENABLE;
-       PHY_WRITE(sc, E1000_CR, reg | E1000_CR_RESET);
+       reg = PHY_READ(sc, MII_BMCR);
+       reg &= ~BMCR_AUTOEN;
+       PHY_WRITE(sc, MII_BMCR, reg | BMCR_RESET);
 }
 
 static int
@@ -392,8 +392,8 @@
                 * isolate ourselves.
                 */
                if (IFM_INST(ife->ifm_media) != sc->mii_inst) {
-                       bmcr = PHY_READ(sc, E1000_CR);
-                       PHY_WRITE(sc, E1000_CR, bmcr | E1000_CR_ISOLATE);
+                       bmcr = PHY_READ(sc, MII_BMCR);
+                       PHY_WRITE(sc, MII_BMCR, bmcr | BMCR_ISO);
                        return (0);
                }
 
@@ -410,8 +410,8 @@
                 * software reset for the settings to take effect.
                 */
                if (IFM_SUBTYPE(ife->ifm_media) != IFM_AUTO) {
-                       bmcr = PHY_READ(sc, E1000_CR);
-                       PHY_WRITE(sc, E1000_CR, bmcr | E1000_CR_RESET);
+                       bmcr = PHY_READ(sc, MII_BMCR);
+                       PHY_WRITE(sc, MII_BMCR, bmcr | BMCR_RESET);
                }
                break;
 
@@ -423,12 +423,12 @@
                        return (0);
 
                if (mii_phy_tick(sc) == EJUSTRETURN)
-                        return (0);
+                       return (0);
                break;
 
        case MII_DOWN:
                mii_phy_down(sc);
-                return (0);
+               return (0);
        }
 
        /* Update the media status. */
@@ -448,13 +448,19 @@
        mii->mii_media_status = IFM_AVALID;
        mii->mii_media_active = IFM_ETHER;
 
-       bmcr = PHY_READ(sc, E1000_CR);
+       bmcr = PHY_READ(sc, MII_BMCR);
        ssr = PHY_READ(sc, E1000_SSR);
 
        if (ssr & E1000_SSR_LINK)
                mii->mii_media_status |= IFM_ACTIVE;
 
-       if (bmcr & E1000_CR_LOOPBACK)
+       if (bmcr & BMCR_ISO) {
+               mii->mii_media_active |= IFM_NONE;
+               mii->mii_media_status = 0;
+               return;
+       }
+
+       if (bmcr & BMCR_LOOP)
                mii->mii_media_active |= IFM_LOOP;
 
        if (!(ssr & E1000_SSR_SPD_DPLX_RESOLVED)) {
@@ -480,8 +486,8 @@
                mii->mii_media_active |= IFM_HDX;
 
        if (IFM_SUBTYPE(mii->mii_media_active) == IFM_1000_T) {
-               gsr = PHY_READ(sc, E1000_1GSR) | PHY_READ(sc, E1000_1GSR);
-               if (gsr & E1000_1GSR_MS_CONFIG_RES)
+               gsr = PHY_READ(sc, MII_100T2SR) | PHY_READ(sc, MII_100T2SR);
+               if (gsr & GTSR_MS_RES)
                        mii->mii_media_active |= IFM_ETH_MASTER;
        }
 }



Home | Main Index | Thread Index | Old Index