Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/ic Use m_remove_pkthdr() instead of "&= ~M_PKTHDR", ...



details:   https://anonhg.NetBSD.org/src/rev/2052d12369ea
branches:  trunk
changeset: 319503:2052d12369ea
user:      maxv <maxv%NetBSD.org@localhost>
date:      Fri Jun 01 09:10:52 2018 +0000

description:
Use m_remove_pkthdr() instead of "&= ~M_PKTHDR", to ensure the tags get
freed. Several other drivers have this problem it seems...

diffstat:

 sys/dev/ic/rtl8169.c |  8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diffs (36 lines):

diff -r a4aec431bc25 -r 2052d12369ea sys/dev/ic/rtl8169.c
--- a/sys/dev/ic/rtl8169.c      Fri Jun 01 08:56:00 2018 +0000
+++ b/sys/dev/ic/rtl8169.c      Fri Jun 01 09:10:52 2018 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: rtl8169.c,v 1.152 2017/09/26 07:42:06 knakahara Exp $  */
+/*     $NetBSD: rtl8169.c,v 1.153 2018/06/01 09:10:52 maxv Exp $       */
 
 /*
  * Copyright (c) 1997, 1998-2003
@@ -33,7 +33,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: rtl8169.c,v 1.152 2017/09/26 07:42:06 knakahara Exp $");
+__KERNEL_RCSID(0, "$NetBSD: rtl8169.c,v 1.153 2018/06/01 09:10:52 maxv Exp $");
 /* $FreeBSD: /repoman/r/ncvs/src/sys/dev/re/if_re.c,v 1.20 2004/04/11 20:34:08 ru Exp $ */
 
 /*
@@ -1189,7 +1189,7 @@
                        if (sc->re_head == NULL)
                                sc->re_head = sc->re_tail = m;
                        else {
-                               m->m_flags &= ~M_PKTHDR;
+                               m_remove_pkthdr(m);
                                sc->re_tail->m_next = m;
                                sc->re_tail = m;
                        }
@@ -1276,7 +1276,7 @@
                                m_freem(m);
                        } else {
                                m->m_len -= ETHER_CRC_LEN;
-                               m->m_flags &= ~M_PKTHDR;
+                               m_remove_pkthdr(m);
                                sc->re_tail->m_next = m;
                        }
                        m = sc->re_head;



Home | Main Index | Thread Index | Old Index