Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

src: Add one more XXX in the list.



details:   https://anonhg.NetBSD.org/src/rev/5ad5bfc50d6c
branches:  trunk
changeset: 318047:5ad5bfc50d6c
user:      maxv <maxv%NetBSD.org@localhost>
date:      Wed Apr 11 06:37:32 2018 +0000
description:
Add one more XXX in the list.

diffstat:

 sys/netmpls/mpls_ttl.c |  12 +++++++-----
 1 files changed, 7 insertions(+), 5 deletions(-)

diffs (34 lines):

diff -r 748773c928b7 -r 5ad5bfc50d6c sys/netmpls/mpls_ttl.c
--- a/sys/netmpls/mpls_ttl.c    Wed Apr 11 06:26:00 2018 +0000
+++ b/sys/netmpls/mpls_ttl.c    Wed Apr 11 06:37:32 2018 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: mpls_ttl.c,v 1.11 2018/01/19 14:15:35 maxv Exp $ */
+/*     $NetBSD: mpls_ttl.c,v 1.12 2018/04/11 06:37:32 maxv Exp $ */
 
 /*
  * Copyright (c) 2010 The NetBSD Foundation, Inc.
@@ -97,7 +97,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: mpls_ttl.c,v 1.11 2018/01/19 14:15:35 maxv Exp $");
+__KERNEL_RCSID(0, "$NetBSD: mpls_ttl.c,v 1.12 2018/04/11 06:37:32 maxv Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_inet.h"
@@ -146,10 +146,12 @@
 /*
  * Send an ICMP Extended error message. References: RFC4884 and RFC4950.
  *
- * This should be in sync with icmp_error() in sys/netinet/ip_icmp.c
- * XXX: is called only for ICMP_TIMXCEED_INTRANS but code is too general.
+ * XXX: This code is inspired from icmp_error(), and should really be merged
+ * into it. icmp_error() should handle ICMP Extended error messages.
  *
- * XXX We're not setting the 'length' field of the Extended ICMP header.
+ * XXX: It is called only for ICMP_TIMXCEED_INTRANS but code is too general.
+ *
+ * XXX: We're not setting the 'length' field of the Extended ICMP header.
  * According to RFC4884, we are in 'non-compliant' mode. Moreover, we're
  * not computing the checksum of the Extended ICMP header.
  */



Home | Main Index | Thread Index | Old Index