Re: proposed pullup request to remove DIAGNOSTIC/DEBUG from netbsd-5

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Wed, Mar 25, 2015 at 06:55:52PM -0400, Greg Troxel wrote:
> [...]
> It's not useful to remove these to hide the bug, but they do slow down
> the kernel, especially DEBUG.  And normal policy is that DIAGNOSTIC is
> enabled in -current and not on release branches, and DEBUG (and
> LOCKDEBUG, etc.) is always off.

I think this policy was not already in place when netbsd-5 was
branched.

> 
> This patch moves netbsd-5 back to the normal policy.  I've tested
> kernels with this change: amd64 dom0, i386 domU.   I intend to submit a
> pullup request to have this applied; speak up if you think I shouldn't.

I wonder if this could cause new bugs to show up. netbsd-5 has not
been that well tested without DEBUG/DIAGNOSTIC for Xen ...

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--