Port-xen archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: [PATCH v3 2/7] pci: Do not ignore device's PXM information



>>> On 09.02.15 at 21:04, <boris.ostrovsky%oracle.com@localhost> wrote:
> If ACPI provides PXM data for IO devices then dom0 will pass it to
> hypervisor during PHYSDEVOP_pci_device_add call. This information,
> however, is currently ignored.
> 
> We will store this information (in the form of nodeID) in pci_dev
> structure so that we can provide it, for example, to the toolstack
> when it adds support (in the following patches) for querying the
> hypervisor about device topology
> 
> We will also print it when user requests device information dump.
> 
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky%oracle.com@localhost>

I disagree with the title - you still effectively ignore the value.
Displaying it upon debug key request doesn't really count as a
use. The patch itself, otoh is fine, so with the title adjusted to
state reality
Acked-by: Jan Beulich <jbeulich%suse.com@localhost>

Jan



Home | Main Index | Thread Index | Old Index