Port-xen archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Panic on dom0 shutdown



On Tue, Jan 08, 2013 at 12:47:17AM +0100, Johan Ihrén wrote:
> Hi Manuel,
> 
> On Jan 7, 2013, at 11:39 , Manuel Bouyer wrote:
> 
> > On Thu, Jan 03, 2013 at 10:54:41AM +0100, Johan Ihrén wrote:
> >>> points to; and this is where the faulty bus_space_read_4() is happening 
> >>> ...
> >> 
> >> Hmm. So using "-fno-optimize-sibling-calls" is not sufficient to avoid all 
> >> tail-calls? Is there any other way of forcing no tail-calls? Otherwise it 
> >> would seem that while tail-calls obviously improve performace they also 
> >> make debugging... close to impossible.
> > 
> > Did you make a build from scratch ? maybe not all files got rebuilt with
> > -fno-optimize-sibling-calls ?
> 
> Yes, this is with the kernel rebuilt from scratch. Still the same trace.

OK, so can you try the attached patch (in addition to building with
-fno-optimize-sibling-calls) ?

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--
Index: sys/arch/xen/xen/evtchn.c
===================================================================
RCS file: /cvsroot/src/sys/arch/xen/xen/evtchn.c,v
retrieving revision 1.62
diff -u -p -u -r1.62 evtchn.c
--- sys/arch/xen/xen/evtchn.c   12 Feb 2012 14:24:08 -0000      1.62
+++ sys/arch/xen/xen/evtchn.c   8 Jan 2013 09:56:15 -0000
@@ -598,6 +598,7 @@ pirq_interrupt(void *arg)
        if (ih->evtch == IRQ_DEBUG)
            printf("pirq_interrupt irq %d ret %d\n", ih->pirq, ret);
 #endif
+       __asm volatile("nop");
        return ret;
 }
 


Home | Main Index | Thread Index | Old Index