Port-xen archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: xen spl rework

On Sun, Nov 25, 2012 at 02:29:50PM -0600, Cherry G. Mathew wrote:
> I've updated the patch with your suggestions.
> ftp://ftp.netbsd.org/pub/NetBSD/misc/cherry/tmp/port-xen/spl1.c.diff

Cosmetic first:
move extern variable and function declaration to hearders, included by
all .c that need it. It's way too easy for things to get out of
sync otherwise.

in evtchn_do_event() seems to not be used anymore (it's computed but
never read).
And, more important, what is setting bits in ci->ci_ipending now ?
It seems that hypervisor_set_ipending() is never called any more ?

Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference

Home | Main Index | Thread Index | Old Index