Re: [Xen-devel] [PATCH v2 1/3] libxc: add suport for NetBSD gntdev

[Ian Campbell <Ian.Campbell%citrix.com@localhost>]

On Thu, 2012-11-29 at 17:31 +0000, Roger Pau Monne wrote:
> Add OS specific handlers for NetBSD gntdev. The main difference is
> that NetBSD passes the VA where the grant should be set inside the
> IOCTL_GNTDEV_MAP_GRANT_REF ioctl, instead of using mmap (this is due
> to OS constraints).
> 
> Signed-off-by: Roger Pau Monné <roger.pau%citrix.com@localhost>

Is anyone from the NetBSD camp likely to review this code?

Otherwise I'm minded to just throw it in, given that it looks OK to
me ;-)

> +static int netbsd_gnttab_set_max_grants(xc_gnttab *xch, xc_osdep_handle h,
> +                                       uint32_t count)
> +{
> +    /* NetBSD doesn't implement this feature */
> +    return 0;
> +}

Is -ENOSYS or "errno=ENOSYS; return -1" more appropriate then?

Ian.