Re: patch: make dmesg more pretty

[Christoph Egger <Christoph_Egger%gmx.de@localhost>]

On Monday 23 July 2007 09:41:22 Antti Kantee wrote:
> On Mon Jul 23 2007 at 09:19:18 +0200, Christoph Egger wrote:
> > On Thursday 19 July 2007 13:58:26 Christoph Egger wrote:
> > > Hi!
> > >
> > > There's a missing new line in arch/x86/pci/pci_machdep.c.
> > > Patch is attached.
> > >
> > >
> > > Without the patch I get:
> > > pci0 at hypervisor0 bus 0: configuration mode 1hypervisor0: added to
> > > list as bus 0
> > >
> > > With the patch I get:
> > >
> > > pci0 at hypervisor0 bus 0: configuration mode 1
> > > hypervisor0: added to list as bus 0
> >
> > @Matt Fleming: Thanks for committing this - and for undo'ing this
> > on Antti's request.
> >
> > @Antti Kantee: Why is this newline bad?
>
> With that patch I (and most everyone else) get:
> pci0 at mainbus0 bus 0: configuration mode 1
>
> pci0: i/o space, memory space enabled, rd/line, rd/mult, wr/inv ok
>
> I wasn't saying the newline is bad, just that it needs more careful
> placement (location left as a brainteaser to the reader ;).

So the newline should be added in the verbose messages instead
(see attached patch)?

I now get this:

pci0 at hypervisor0 bus 0: configuration mode 1
hypervisor0: added to list as bus 0
pci0: i/o space, memory space enabled

Without the attached patch, I get this:

pci0 at hypervisor0 bus 0: configuration mode 1hypervisor0: added to list as 
bus 0
<blank line>
pci0: i/o space, memory space enabled


Christoph

? x86_mp.diff
Index: mpacpi.c
===================================================================
RCS file: /cvsroot/src/sys/arch/x86/x86/mpacpi.c,v
retrieving revision 1.48
diff -u -p -r1.48 mpacpi.c
--- mpacpi.c    10 Apr 2007 12:15:27 -0000      1.48
+++ mpacpi.c    23 Jul 2007 07:57:14 -0000
@@ -1076,7 +1076,7 @@ mpacpi_pci_attach_hook(struct device *pa
        mpb->mb_pci_chipset_tag = pba->pba_pc;
 
        if (mp_verbose)
-               printf("%s: added to list as bus %d\n", parent->dv_xname,
+               printf("\n%s: added to list as bus %d", parent->dv_xname,
                    pba->pba_bus);
 
 
Index: mpbios.c
===================================================================
RCS file: /cvsroot/src/sys/arch/x86/x86/mpbios.c,v
retrieving revision 1.36
diff -u -p -r1.36 mpbios.c
--- mpbios.c    28 Apr 2007 14:51:58 -0000      1.36
+++ mpbios.c    23 Jul 2007 07:57:14 -0000
@@ -1191,7 +1191,7 @@ mpbios_pci_attach_hook(struct device *pa
                mpb->mb_name = "pci";
 
        if (mp_verbose)
-               printf("%s: added to list as bus %d\n", parent->dv_xname,
+               printf("\n%s: added to list as bus %d", parent->dv_xname,
                    pba->pba_bus);
 
        mpb->mb_configured = 1;