Subject: Re: patch: make dmesg more pretty
To: Christoph Egger <Christoph_Egger@gmx.de>
From: Antti Kantee <pooka@netbsd.org>
List: port-xen
Date: 07/23/2007 10:41:22
On Mon Jul 23 2007 at 09:19:18 +0200, Christoph Egger wrote:
> On Thursday 19 July 2007 13:58:26 Christoph Egger wrote:
> > Hi!
> >
> > There's a missing new line in arch/x86/pci/pci_machdep.c.
> > Patch is attached.
> >
> >
> > Without the patch I get:
> > pci0 at hypervisor0 bus 0: configuration mode 1hypervisor0: added to list
> > as bus 0
> >
> > With the patch I get:
> >
> > pci0 at hypervisor0 bus 0: configuration mode 1
> > hypervisor0: added to list as bus 0
> 
> @Matt Fleming: Thanks for committing this - and for undo'ing this
> on Antti's request.
> 
> @Antti Kantee: Why is this newline bad? 

With that patch I (and most everyone else) get:
pci0 at mainbus0 bus 0: configuration mode 1

pci0: i/o space, memory space enabled, rd/line, rd/mult, wr/inv ok

I wasn't saying the newline is bad, just that it needs more careful
placement (location left as a brainteaser to the reader ;).

-- 
Antti Kantee <pooka@iki.fi>                     Of course he runs NetBSD
http://www.iki.fi/pooka/                          http://www.NetBSD.org/
    "la qualité la plus indispensable du cuisinier est l'exactitude"