Port-xen archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Minor precedence issues in pmap_remap_pages()?



> > diff -u -r1.8.2.3 pmap.c
> > --- sys/arch/xen/i386/pmap.c    6 Jun 2005 12:16:10 -0000       1.8.2.3
> > +++ sys/arch/xen/i386/pmap.c    21 Jul 2005 03:55:43 -0000
> > @@ -3715,7 +3715,7 @@
> >                  * wired count might change...
> >                  */
> >                 pmap->pm_stats.wired_count +=
> > -                   ((npte & PG_W) ? 1 : 0 - (opte & PG_W) ? 1 : 0);
> > +                   ((npte & PG_W) ? 1 : 0) - ((opte & PG_W) ? 1 : 0);
> 
> Anyone object to my committing them, now that I can do that?  It's
> pretty obvious that the code is wrong as is, and that my parens are
> what was meant.

please go ahead.  don't forget to fix i386 version as well.

YAMAMOTO Takashi



Home | Main Index | Thread Index | Old Index