Subject: Re: CVS commit: syssrc
To: Izumi Tsutsui <>
From: Jaromir Dolecek <>
List: port-sun3
Date: 10/17/1999 13:21:54

What is the right think to do for sun3 and and it's local definition
of Debugger() in non-DDB case ? Should the Debugger() function be
there even for non-DDB case ? IMHO it's use is limited in that
case, since MI code calls Debugger() only when DDB is configured
in.  MD code (like zs driver) can surely take advantage of fact that
the functionality is always available. But it's use is at least
inconsistent (dev/si.c & dev/fd.c call Debugger() only when DDB,
other code uncoditionally).

The right thing to do seems to be to keep the fuction (even for
non-DDB case), rename it to cpu_Debugger() (i.e. the same
as the one in m68k/m68k/db_interface.c) and either update callers
or provide approptiate define. It would be fine to make it's usage
more consistent too and call it unconditionally from dev/si.c and
dev/fd.c. IMHO the <sys/systm.h> should be changed to provide the
cpu_Debugger() prototype and Debugger define for __sparc__ even
when DDB is not defined and the prototype for Debugger() in
sun3/machdep.h and other files should be killed.

The contents of sun3/stub.c should be maybe moved do sun3/conf.c
or sun3/machdep.c IMHO, but I'm not sure which staff is normally
put to either of those files.

Opinions ?

Please keep me on CC since I'm not subscribed into this list.


Izumi Tsutsui wrote:
> In <>
> wrote:
> > Module Name:	syssrc
> > Committed By:	jdolecek
> > Date:		Sun Oct 17 09:32:16 UTC 1999
> > 
> > Modified Files:
> > 	syssrc/sys/arch/sun3/dev: zs.c
> > 
> > Log Message:
> > include opt_ddb.h, so that symbol DDB actually get's defined appropriately
> > kill local definition of Debugger() - <sys/systm.h> DTRT
> > don't assume Debugger() is always available and put the call inside #ifdef DDB
> On sun3 port, Debugger() is defined in sun3/stub.c if DDB is not defined.
> I'm not sure whether it is appropriate, though.
Jaromir Dolecek <>
"The only way how to get rid temptation is to yield to it." -- Oscar Wilde