Subject: Re: net troubles
To: None <eeh@netbsd.org, tn@catvmics.ne.jp>
From: None <eeh@netbsd.org>
List: port-sparc64
Date: 06/12/2002 17:02:00
| >>> eeh@netbsd.org wrote
|
| > After looking at what you did to _bus_dmamap_load_mbuf() I 
| > cannot see anything that would change it's behavior.  Other
| > than limiting the numver of segments used to map->_dm_segcnt
| > it should result in the exact same data layout as the old
| > version.
|
| Thanks for reviewing my patch.
|
| I saw that it is not suitable to check the segments limit by
| map->_dm_segcnt in _bus_dmamap_load_mbuf().
|
| In this case, only when segments fragmentation occurs, it passes
| the limitation check in dev/iommu.c. So, we need to check like the
| attached patch I revised. The important part is the 2nd chunk of
| dev/iommu.c.
|
| I also revised _bus_dmamap_load() more properly.
|
| Please review my patch again.

Looks good.  I've tested it a bit and found no breakage on other
machines.  I'm going to tweak _bus_dmamap_load() a teeny bit and
check it in.

Eduardo