Re: What is going on with stand/ofwboot?

[christos%astron.com@localhost (Christos Zoulas)]

In article <20110521.163554.269452255.he%uninett.no@localhost>,
Havard Eidnes  <he%NetBSD.org@localhost> wrote:
>>> I tried to fix a few occasions, but it looks like the ofwboot sources could
>>> do with a bit of re-organizing from somebody in the know - it's more than
>>> just the occasional missing prototype.
>>
>> net_open() in net.c stores a socket statically, so it looks net_tftp_bootp()
>> after net_open() doesn't have to return the socket in this case.
>> (probably busted of->f_devdata was not refered after that call fortunately)
>
>You probably saw that I made a commit which fixes the build, but
>which doesn't re-do how net_tftp_bootp() behaves, and which now
>requires an ugly cast (which I added).
>
>Feel free to add your changes on top of the ones I made to make
>it build again, that is, unless someone more authoritative has
>any objections to the suggested changes.
>
>BTW, won't your new net_tftp_bootp() get a warning for an unused
>function argument?
>
>And... this one:
>
>> -    memset(promops, 0, sizeof(promops));
>> +    memset(&promops, 0, sizeof(promops));
>
>... looks like an ancient and somewhat unrelated bug(?)

Well this is what adding -std=gnu99 has done. Unearth ancient bugs.

christos