Port-sparc archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: hme(4) hardware RX checksum



naoki%fukaumi.org@localhost wrote:

> I'm sorry this is another topic but I remembered suddenly...
> 
> sys/dev/ic/hme.c has ether_cmp(), it returns 1 if two ethernet addresses
> are identical. it is (only) used in hme_setladrf().
> 
> it should be eliminated and replaced by memcmp(), otherwise IFF_ALLMULTI
> is set unexpectedly.

Fixed, it's always better to file a PR if you see any problems :-)
---
Izumi Tsutsui


Home | Main Index | Thread Index | Old Index