Port-sparc archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: hme(4) hardware RX checksum



In article <090307001037.M0119818%mirage.ceres.dti.ne.jp@localhost>,
Izumi Tsutsui  <tsutsui%ceres.dti.ne.jp@localhost> wrote:
>In hme.c:hme_get(), m_pkthdr.csum_flags is always cleared after
>a goto label, so hardware RX checksum on hme(4) seems unused at all.
>(no one has checked hwcsum stats by options TCP_CSUM_COUNTERS etc?)
>
>There is also a wrong pointer arith in VLAN case.
>
>Is it okay to commit this fix?

Please do!

christos



Home | Main Index | Thread Index | Old Index