Subject: Re: sys/arch/sparc/dev/ts102.c
To: Hisashi T Fujinaka <htodd@twofifty.com>
From: Michael <macallan18@earthlink.net>
List: port-sparc
Date: 07/12/2005 21:38:31
--Signature_Tue__12_Jul_2005_21_38_32_-0400_CwHe6EbqkM9qM/L4
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hello,

> I think we're compiling with -Werror? Anyway, on line 760 "i" is
> declared as an int but it's not used if NTCTRL <=3D 0 (there's an
> ifdef).
> That breaks the build and I haven't looked into what NTCTRL is yet.

Fixed it.

NTCTRL is declared when the tctrl driver which talks to the SPARCbook's
microcontroller is compiled in, as far as I can tell there is no
hardware that has a ts102 but no tctrl ( in fact the microcontroller
interface is on the same chip as the PCMCIA bridge, they have only
separate entries in the device tree )

Which kernel did you try to compile? GENERIC has both tctrl and tslot so
NTCTRL should be 1 and the build should succeed.

have fun
Michael

--Signature_Tue__12_Jul_2005_21_38_32_-0400_CwHe6EbqkM9qM/L4
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (NetBSD)

iQEVAwUBQtRwncpnzkX8Yg2nAQL9Qwf9EhO4fBduJ32wL4D+wlqqPTz5T2brlf7d
0SLDLPqA6QXppSom4NZiqSUBlbbEo04IxNSv1s7blT0WppM4pf7MV6GpXG5KhGl2
xZLPcwwjc6iTppxdjnT8KFKgpPD7t29qq4XKRBTvEiFTxYA7T2oHW8llKDh6z9FH
E0rMYst6eHdMe5e4rMJHGwbJeYfXwpV/I42F+5CaoVdACYqSGRAIKq2uertIgggL
SJ0GufWuVMMEeQEKGIJ9+v0EYxX4PBILH0WpeMreGpF/N+f3Ain/qi+6igp3qnRb
PBvkLooomxeQgL/3NjGYlRqdM2Q5LXl7xyipC2iII/BmBuNif/mfbg==
=JEUj
-----END PGP SIGNATURE-----

--Signature_Tue__12_Jul_2005_21_38_32_-0400_CwHe6EbqkM9qM/L4--