Subject: Re: ATM en0 driver on sbus
To: Ruibiao Qiu <ruibiao@arl.wustl.edu>
From: Eduardo E. Horvath <eeh@one-o.com>
List: port-sparc
Date: 08/14/1998 19:52:14
On Fri, 14 Aug 1998, Ruibiao Qiu wrote:
> tOn Fri, 14 Aug 1998, Chuck Cranor wrote:
>
> >In your letter dated Fri, 14 Aug 1998 12:52:34 -0500 (CDT), you wrote:
> >in the short term, the quick hack would be to switch to using
> >the #define for bus_space_read_4/bus_space_write_4 in
> >sys/arch/sparc/include/bus.h (deleting the fake ones in midwayreg.h).
>
> This doesn't seem work. I commented out the old #define
> bus_space_read_4 and bus_space_write_4, and copied those #defines
> from sys/arch/sparc/include/bus.h into midwayreg.h. This time,
> the midway.c compiled, but if_en.c caused errors of conflicting
> types of bus_space_tag_t, bus_space_handle_t, bus_size_t,
> bus_addr_t. And there are also prototype mismatch errors. Should
> I change the include file in if_en.c?
No. Don't copy defines. Those fake defines were designed to get around a
problem that no longer exists. Take a look at who includes what and
arrange for the real sparc/include/bus.h to be included. I think,
looking at if_en.c, that the proper dev/sbus/sbus.h is being included.
Maybe the only thing you need to do is remove the `#if defined(sparc)'
from midwayreg.h
=========================================================================
Eduardo Horvath eeh@one-o.com
"I need to find a pithy new quote." -- me