devel/libffi

[Havard Eidnes <he%NetBSD.org@localhost>]

Hi,

it appears that devel/libffi fails to build for any of our
powerpc ports.  As a consequence, lang/python25 also fails to
build (I suspect it has an internal, possibly an older copy of
libffi).

The attached patch upgrades devel/libffi from 3.0.6 to 3.0.8, and
treats our powerpc ports the same way FreeBSD does.  However,
that is probably not correct (I don't know).

I've installed devel/dejagnu, and done "make test", and that gets
me the following summary:

                === libffi Summary ===

# of expected passes            1384
# of unexpected failures        5
# of unsupported tests          15
*** Error code 1

A more detailed copy of the output from "make test" follows
attached below.

It would be much appreciated if some of you more powerpc-adept
people could take a closer look at porting this package for the
NetBSD/powerpc ports.

Best regards,

- Håvard

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/devel/libffi/Makefile,v
retrieving revision 1.8
diff -u -p -r1.8 Makefile
--- Makefile    11 Oct 2008 22:33:56 -0000      1.8
+++ Makefile    18 Jan 2009 15:12:11 -0000
@@ -1,7 +1,7 @@
 # $NetBSD: Makefile,v 1.8 2008/10/11 22:33:56 dholland Exp $
 #
 
-DISTNAME=      libffi-3.0.6
+DISTNAME=      libffi-3.0.8
 CATEGORIES=    devel
 MASTER_SITES=  ftp://sourceware.org/pub/libffi/
 
@@ -18,6 +18,8 @@ USE_TOOLS+=   pkg-config
 USE_LANGUAGES= c c++
 INFO_FILES=    # PLIST
 
+TEST_TARGET=   check
+
 PKGCONFIG_OVERRIDE+=   libffi.pc.in
 
 .include "../../mk/bsd.pkg.mk"
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/devel/libffi/distinfo,v
retrieving revision 1.9
diff -u -p -r1.9 distinfo
--- distinfo    11 Oct 2008 22:33:56 -0000      1.9
+++ distinfo    18 Jan 2009 15:12:11 -0000
@@ -1,7 +1,9 @@
 $NetBSD: distinfo,v 1.9 2008/10/11 22:33:56 dholland Exp $
 
-SHA1 (libffi-3.0.6.tar.gz) = 04a5f38c76dfe3e078767645ca89f2ff71721104
-RMD160 (libffi-3.0.6.tar.gz) = da8f547209e6b13dc7be86ea29ad5fa5e85844e5
-Size (libffi-3.0.6.tar.gz) = 717171 bytes
+SHA1 (libffi-3.0.8.tar.gz) = ce44d10c39d9a37479c8777e206cac0f36c48712
+RMD160 (libffi-3.0.8.tar.gz) = 4144f64e79ebf95161a6afd58ceaeef8372b5e57
+Size (libffi-3.0.8.tar.gz) = 722834 bytes
 SHA1 (patch-ac) = 307c08e8e3df5f079c0b2f63da58bb59fc089d30
 SHA1 (patch-ad) = 8901a00abe25422e3e35f321a5fb89311185fc0b
+SHA1 (patch-ae) = bf16fd422f2d705324bd8a113f5681252f6c6bdc
+SHA1 (patch-af) = cb6cdffa127f34b1e6f299f76de08bff20ab83dd
--- /dev/null   2009-01-18 16:06:30.000000000 +0100
+++ patches/patch-ae    2009-01-18 15:47:54.000000000 +0100
@@ -0,0 +1,13 @@
+$NetBSD$
+
+--- configure.ac.orig  2008-12-19 17:12:30.000000000 +0100
++++ configure.ac
+@@ -118,7 +118,7 @@ case "$host" in
+   powerpc-*-aix* | rs6000-*-aix*)
+       TARGET=POWERPC_AIX; TARGETDIR=powerpc
+       ;;
+-  powerpc-*-freebsd*)
++  powerpc-*-freebsd* | powerpc-*-netbsd*)
+       TARGET=POWERPC_FREEBSD; TARGETDIR=powerpc
+       ;;
+   powerpc*-*-rtems*)
--- /dev/null   2009-01-18 16:06:30.000000000 +0100
+++ patches/patch-af    2009-01-18 15:48:54.000000000 +0100
@@ -0,0 +1,13 @@
+$NetBSD$
+
+--- configure.orig     2009-01-18 15:46:33.000000000 +0100
++++ configure
+@@ -21033,7 +21033,7 @@ case "$host" in
+   powerpc-*-aix* | rs6000-*-aix*)
+       TARGET=POWERPC_AIX; TARGETDIR=powerpc
+       ;;
+-  powerpc-*-freebsd*)
++  powerpc-*-freebsd* | powerpc-*-netbsd*)
+       TARGET=POWERPC_FREEBSD; TARGETDIR=powerpc
+       ;;
+   powerpc*-*-rtems*)

===> Testing for libffi-3.0.8
Making check in include
Making check in testsuite
/usr/bin/make  check-DEJAGNU
srcdir=`CDPATH="${ZSH_VERSION+.}:" && cd . && pwd`; export srcdir;  EXPECT=`if 
[ -f ../../expect/expect ] ; then  echo ../../expect/expect ;  else echo expect 
; fi`; export EXPECT;  runtest=`if [ -f ../../dejagnu/runtest ] ; then  echo 
../../dejagnu/runtest ;  else echo runtest; fi`;  if /bin/sh -c "$runtest 
--version" > /dev/null 2>&1; then  exit_status=0; l='libffi'; for tool in $l; 
do  if $runtest  --tool $tool --srcdir $srcdir ;  then :; else exit_status=1; 
fi;  done;  else echo "WARNING: could not find \`runtest'" 1>&2; :; fi;  exit 
$exit_status
WARNING: Couldn't find the global config file.
WARNING: Couldn't find tool init file
Test Run By he on Sun Jan 18 16:06:30 2009
Target is powerpc--netbsd
Host   is powerpc--netbsd
Build  is powerpc-unknown-netbsd4.0

                === libffi tests ===

Schedule of variations:
    unix

Running target unix
Using /usr/pkg/share/dejagnu/baseboards/unix.exp as board description file for 
target.
Using /usr/pkg/share/dejagnu/config/unix.exp as generic interface file for 
target.
Using /usr/pkgsrc/devel/libffi/work/libffi-3.0.8/testsuite/config/default.exp 
as tool-and-target-specific interface file.
WARNING: Assuming target board is the local machine (which is probably wrong).
You may need to set your DEJAGNU environment variable.
Running 
/usr/pkgsrc/devel/libffi/work/libffi-3.0.8/testsuite/libffi.call/call.exp ...
FAIL: libffi.call/float2.c -O0 -W -Wall (test for excess errors)
FAIL: libffi.call/cls_6byte.c -O2 output pattern test, is 127 120 1 128 12 128 
9 127: 139 248 10 255
res: 139 248 10 255
0 120 1 128 12 128 9 127: 12 248 10 255
res: 12 248 10 255
? should match 127 120 1 128 12 128 9 127: 139 248 10 255
?es: 139 248 10 255
?27 120 1 128 12 128 9 127: 139 248 10 255
res: 139 248 10 255
FAIL: libffi.call/cls_6byte.c -O3 output pattern test, is 127 120 1 128 12 128 
9 127: 139 248 10 255
res: 139 248 10 255
0 120 1 128 12 128 9 127: 12 248 10 255
res: 12 248 10 255
? should match 127 120 1 128 12 128 9 127: 139 248 10 255
?es: 139 248 10 255
?27 120 1 128 12 128 9 127: 139 248 10 255
res: 139 248 10 255
FAIL: libffi.call/cls_6byte.c -Os output pattern test, is 127 120 1 128 12 128 
9 127: 139 248 10 255
res: 139 248 10 255
0 120 1 128 12 128 9 127: 12 248 10 255
res: 12 248 10 255
? should match 127 120 1 128 12 128 9 127: 139 248 10 255
?es: 139 248 10 255
?27 120 1 128 12 128 9 127: 139 248 10 255
res: 139 248 10 255
FAIL: libffi.call/cls_6byte.c -O2 -fomit-frame-pointer output pattern test, is 
127 120 1 128 12 128 9 127: 139 248 10 255
res: 139 248 10 255
0 120 1 128 12 128 9 127: 12 248 10 255
res: 12 248 10 255
? should match 127 120 1 128 12 128 9 127: 139 248 10 255
?es: 139 248 10 255
?27 120 1 128 12 128 9 127: 139 248 10 255
res: 139 248 10 255
Running 
/usr/pkgsrc/devel/libffi/work/libffi-3.0.8/testsuite/libffi.special/special.exp 
...

                === libffi Summary ===

# of expected passes            1384
# of unexpected failures        5
# of unsupported tests          15
*** Error code 1

Stop.