Re: Location of PIC modules

[Robert Swindells <rjs%fdy2.demon.co.uk@localhost>]

Tim Rightnour wrote:
>On 21-May-2008 Michael Lorenz wrote:
>> I think port-specific code should live in port-specific directories.
>> Frankly,  don't see how lumping them all together would ease  
>> maintenance - quite the opposite actually, it would just add clutter.

>It occurred to me that it's really easy to forget that one or more of
>them exist when making a change that has to be reflected in all the
>different PIC's.  It's also slightly easier to look at all the
>different ones when writing a new one if they are all in one place.

>It might also be nice to have the config logic all in one file too,
>rather than spread across the different port files.

>No major technical reason for it, just that it seems more organized to
>me that way.  I'm not set in stone on it, so I thought it would be
>good to put it out there.

What about the PICNODE_* IDs ? Do you think powerpc/include/pci_machdep.h
is the best place for them ?

Robert Swindells