Re: FirePower (was Re: TODO list for ofppc)

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

root%garbled.net@localhost wrote:

> OK, I see what is going on here, but I'm not immediately sure what the right
> fix is.  In powerpc/oea/ofwoea_machdep.c:find_ranges() we dig out the number 
> of
> address cells, the number of size cells, and then add 1.  On your machines,
> adding 1 seems to be what does it in.

Hmm, but isn't it better to adjust scells?
It's 2, but sizes look to appear at offset 4 (acells is 3 there).
Anyway, I've tried a kernel without the "+ 1".

On FirePower:
---
ok dev /pci
ok .properties
bus-range                00 00 00 00 00 00 00 00 
#size-cells              00000002 
#address-cells           00000003 
device_type              pci
scsi-initiator-id        00000007 
name                     pci
slot-name                00 00 00 0c 53 6c 6f 74 20 41 00 53 6c 6f 74 20 
ranges                   00000000 00000000 00000000 80800800 00000800 00000800 
                         00000000 00000000 80801000 00000800 00001000 00000000 
                         00000000 80802000 00000800 00001800 00000000 00000000 
                         80804000 00000800 00002000 00000000 00000000 80808000 
                         00000800 01000000 00000000 00000000 80000000 00010000 
                         01000000 00000000 00010000 80100000 3e800000 02000000 
                         00000000 00000000 c0000000 3e000000 0072616e 67657386 
ok 

 :

 start=0x100000
Loaded initial symtab at 0x543140, strtab at 0x57be6c, # entries 13643
Copyright (c) 1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004, 2005,
    2006, 2007, 2008
    The NetBSD Foundation, Inc.  All rights reserved.
Copyright (c) 1982, 1986, 1989, 1991, 1993
    The Regents of the University of California.  All rights reserved.

NetBSD 4.99.49 (DEBUG) #6: Wed Jan 23 22:34:23 JST 2008
        tsutsui@mirage:/usr/src/sys/arch/ofppc/compile/DEBUG
total memory = 32768 KB
avail memory = 23816 KB
bootpath: /pci/DEC,ethernet@4/netbsd.ofppc
mainbus0 (root)
cpu0 at mainbus0: 603e (Revision 1.4), ID 0 (primary)
cpu0: HID0 90c000<DOZE,DPM,ICE,DCE>, powersave: 1
ofwpci0 at mainbus0
found a map reclen=5 cur=0 len=160
FOUND PCI RANGE
FOUND PCI RANGE
FOUND PCI RANGE
FOUND PCI RANGE
FOUND PCI RANGE
FOUND PCI RANGE
FOUND PCI RANGE
FOUND PCI RANGE
returning with CUR=7
cur == 7
addr=0x80800800 size=0x800 type=0
addr=0x80801000 size=0x1000 type=0
addr=0x80802000 size=0x1800 type=0
addr=0x80804000 size=0x2000 type=0
addr=0x80808000 size=0x1000000 type=0
addr=0x80000000 size=0x1000000 type=1
addr=0x80100000 size=0x2000000 type=1
range==5
i==0
range==6
i==1
RANGE iomem=1 FOUND
addr=0x80000000 size=0x2100000 type=1
HOLES FOUND
found a map reclen=5 cur=0 len=160
FOUND PCI RANGE
FOUND PCI RANGE
FOUND PCI RANGE
FOUND PCI RANGE
FOUND PCI RANGE
FOUND PCI RANGE
FOUND PCI RANGE
FOUND PCI RANGE
returning with CUR=7
cur == 7
addr=0x80800800 size=0x800 type=0
addr=0x80801000 size=0x1000 type=0
addr=0x80802000 size=0x1800 type=0
addr=0x80804000 size=0x2000 type=0
addr=0x80808000 size=0x1000000 type=0
addr=0x80000000 size=0x1000000 type=1
addr=0x80100000 size=0x2000000 type=1
RANGE iomem=2 FOUND
addr=0x80000000 size=0x2100000 type=1
HOLES FOUND
Data access exception
ok 
---

On ESTRELLA:
---
ok .properties
slot-names               00 00 01 c0 50 43 49 20 31 00 50 43 49 20 32 00 
arc-device-specific      c03e0101 
compatible               IBM,27-82660
aix-id&type              41 d0 0a 03 00 06 04 01 
aix-bus-id               00000004 
ranges                   01000000 00000000 00000000 80000000 00010000 01000000 
                         00000000 01000000 81000000 3e800000 02000000 00000000 
                         00000000 c0000000 3c000000 0072616e 67657386 00058400 
clock-frequency          01f78a40 
bus-range                00 00 00 00 00 00 00 00 
#size-cells              00000002 
#address-cells           00000003 
device_type              pci
scsi-initiator-id        00000007 
name                     pci
ok 

 :

 start=0x100000
Loaded initial symtab at 0x543140, strtab at 0x57be6c, # entries 13643
Copyright (c) 1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004, 2005,
    2006, 2007, 2008
    The NetBSD Foundation, Inc.  All rights reserved.
Copyright (c) 1982, 1986, 1989, 1991, 1993
    The Regents of the University of California.  All rights reserved.

NetBSD 4.99.49 (DEBUG) #6: Wed Jan 23 22:34:23 JST 2008
        tsutsui@mirage:/usr/src/sys/arch/ofppc/compile/DEBUG
total memory = 128 MB
avail memory = 117 MB
bootpath: /pci/ethernet@4/netbsd.ofppc
mainbus0 (root)
cpu0 at mainbus0: 604e (Revision 2.3), ID 0 (primary)
cpu0: HID0 8000c084<EMCP,ICE,DCE,SGE,BHT>, powersave: 1
cpu0: 166.67 MHz
ofwpci0 at mainbus0
found a map reclen=5 cur=0 len=60
FOUND PCI RANGE
FOUND PCI RANGE
FOUND PCI RANGE
returning with CUR=2
cur == 2
addr=0x80000000 size=0x1000000 type=1
addr=0x81000000 size=0x2000000 type=1
range==0
i==0
range==1
i==1
RANGE iomem=1 FOUND
addr=0x80000000 size=0x3000000 type=1
HOLES FOUND
found a map reclen=5 cur=0 len=60
FOUND PCI RANGE
FOUND PCI RANGE
FOUND PCI RANGE
returning with CUR=2
cur == 2
addr=0x80000000 size=0x1000000 type=1
addr=0x81000000 size=0x2000000 type=1
RANGE iomem=2 FOUND
addr=0x80000000 size=0x3000000 type=1
HOLES FOUND
Unhandled pic node type node=7e5ac40
pci0 at ofwpci0 bus 0: OFW method configuration space access
pchb0 at pci0 dev 0 function 0
pchb0: IBM 82660 PowerPC to PCI Bridge and Memory Controller (rev. 0x02)
pchb0: L1: enabled L2: enabled 
pchb0: DRAM EDO (ECC) SRAM sync
pcib0 at pci0 dev 1 function 0: Symphony Labs 83C553 PCI-ISA Bridge (rev. 0x05)
pciide0 at pci0 dev 1 function 1
pciide0: Symphony Labs 82C105 (rev. 0x05)
pciide0: couldn't map native-PCI interrupt
pciide0: couldn't map native-PCI interrupt
esiop0 at pci0 dev 2 function 0: Symbios Logic 53c825a (fast wide scsi)
esiop0: using on-board RAM
panic: intr_establish: bogus IRQ 15, max is -1
Stopped in pid 0.1 (system) at  netbsd:cpu_Debugger+0x10:       lwz     r0, r1, 
0x14
db> 
---

Should we also handle the PIC on this machine as
"Unhandled pic node type node=7e5ac40" message?

> One question, can you show me the .properties of your root node? (on both the 
> firepower, and this Estrella) In both my pegasos, and my 7044, my root node 
> has
> an #address-cells property of "1".  Perhaps your machines are missing that, 
> and
> its something we can key off?

On FirePower:
---
ok dev /
ok .properties
name                     FirePower,Powerized_ES
#address-cells           00000001 
ok 
---

On ESTRELLA (actually it's PowerStack II OEM)
---
ok dev /
ok .properties
system-id                008003E2CA170
name                     MOT,PowerStack_II_Pro4000
clock-frequency          03f8e49b 
arc-identifier           PowerStack
aix-bus-id               00000080 
compatible               prep
#address-cells           00000001 
ok 
---

So both have #address-cells "1".
---
Izumi Tsutsui