Subject: Re: map_isa_ioregs
To: Tim Rightnour <root@garbled.net>
From: Frank Wille <frank@phoenix.owl.de>
List: port-ofppc
Date: 11/08/2007 21:57:49
Tim Rightnour wrote:

>> First, when working with physical console, checking for device_type
>> property "display" fails on the Pegasos. It is called "bootconsole".
>> Additionally, when the pckbc driver is missing, cninit_kd() would just
>> return, instead of falling back to the ofwbootcons.
>> 
>> Second, when using a serial terminal, the check for the name-property
>> "serial" fails, which is "failsafe" here. IMHO this check is not needed
>> at all, because it is a fallback to the ofwbootcons.
> 
> This patch looks good except for where you deleted the section that calls
> the cninit_kbd. macppc needs that code. Can you make cninit_kbd return
> truth of some kind and then fall down?

Did you try it? I think it should still work. Now, cninit_kd() is called
always, when "device_type" is not "serial". Before, it was only called when
"device_type" is "display".

-- 
    _  Frank Wille (frank@phoenix.owl.de)
 _ //  http://sun.hasenbraten.de/~frank/
 \X/   Phx @ #AmigaGer