Port-mips archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: some mips changes for loongson2



On Wed, Aug 10, 2011 at 10:28:11PM +1000, Simon Burge wrote:
 > >  EXPORT(_lock_ras_start)
 > >  STATIC_LEAF(ras_atomic_cas_noupdate)
 > > -  j       ra
 > > +  RETURN
 > >     move   v0, t0
 > >  END(ras_atomic_cas_noupdate)
 > 
 > I _think_ I'd like to see a "j ra" comment on this, but not entirely
 > sure, as we don't use the "RETURN" convention anywhere else.  That said,
 > this hardly looks great either:
 > 
 >      STATIC_LEAF(ras_atomic_cas_noupdate)
 >              RETURN                  /* j ra   on most CPUs */
 >               move   v0, t0
 >      END(ras_atomic_cas_noupdate)

Call the macro J_RA; that'll make it much clearer.

-- 
David A. Holland
dholland%netbsd.org@localhost


Home | Main Index | Thread Index | Old Index