Subject: Re: replace pa_to_pvh() and pa_to_attribute() macro
To: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
From: Simon Burge <simonb@wasabisystems.com>
List: port-mips
Date: 11/23/2005 11:09:54
Izumi Tsutsui wrote:

> Some discussion is going on tech-kern, but is it OK
> to commit the attached diff against mips/pmap.c?

Not inlining these functions results is about 2kB of kernel text saved:

2680 -rwxr-xr-x  1 simonb  wheel  2728338 Nov 23 10:42 netbsd.OLD*
2680 -rwxr-xr-x  1 simonb  wheel  2728338 Nov 23 10:46 netbsd.inline*
2672 -rwxr-xr-x  1 simonb  wheel  2726290 Nov 23 10:47 netbsd.no-inline*

pa_to_pvh() compiles to 184 bytes and pa_to_attribute() compiles to 188
bytes, and there's a few calls to each.

I'm curious to know if there's much of a performance hit at all for not
inlining?

Simon.
--
Simon Burge                            <simonb@wasabisystems.com>
NetBSD Support and Service:         http://www.wasabisystems.com/