Subject: Re: make paddr_t 64bit on arc port
To: Noriyuki Soda <soda@sra.co.jp>
From: Jason R Thorpe <thorpej@zembu.com>
List: port-mips
Date: 06/07/2000 09:31:08
On Wed, Jun 07, 2000 at 11:16:30PM +0900, Noriyuki Soda wrote:

 > I'd like to change paddr_t from 32bit to 64bit on arc port before
 > NetBSD-1.5 branch cut by introducing symbol "_MIPS_PADDR_T_64BIT" in
 > <machine/types.h>.
 > 
 > e.g. the following will be <machine/types.h> of arc port:
 > 	#define _MIPS_PADDR_T_64BIT
 > 	#include <mips/types.h>
 > 
 > The relevant changes to port-independent mips part is attached below,
 > Is there any problem with this?
 > 
 > I will also rename
 > 	vad_to_pfn() -> mips_paddr_to_tlbpfn()
 > 	pfn_to_vad() -> mips_tlbpfn_to_paddr()
 > as Jason suggested on port-mips, Mar 27.

This looks good.  We should probably allow this on the Cobalt port,
as well (it's a MIPS-III port).

 > -	if (pa & 0x80000000)
 > +#endif
 > +#ifdef PARANOIADIAG
 > +#if defined(cobalt) || defined(newsmips) || defined(pmax) /* otherwise ok */
 > +	if (pa & 0x80000000)	/* this is not error in general. */
 >  		panic("pmap_enter: pa");
 > +#endif

...instead of listing the ports, you should test against _MIPS_PADDR_T_64BIT

-- 
        -- Jason R. Thorpe <thorpej@zembu.com>