Subject: Re: CVS commit: src
To: None <jonathan@netbsd.org>
From: Jason Thorpe <thorpej@nas.nasa.gov>
List: port-mips
Date: 12/05/1998 14:34:40
On Sat, 5 Dec 1998 01:13:11 -0800 (PST) 
 Jonathan Stone <jonathan@netbsd.org> wrote:

 > Module Name:	src
 > Committed By:	jonathan
 > Date:		Sat Dec  5 09:13:10 UTC 1998
 > 
 > Modified Files:
 > 	src/sys/arch/mips/mips: pmap.c
 > Log Message:
 > Track PV_REFERENCED bit as for PV_MODIFIED,  to make mdsetimage work correctly.
 > Compatiblity with Mach VM: clear pmap-private bits in pmap_remove() if !UVM.

That latter bit is WRONG.  For example, the hp300 pmap SPECIFICALLY remembers
the ref/mod bits from the PTE in the pmap_attributes entry for that page
when a mapping is removed.

"referenced" and "modifed" are attributes of the hardware page, not the
mapping of it.  Consider if a page is double-mapped.  With your change,
you have now broken mod/ref tracking for double-mapped pages when one
of the mappings is removed.

Jason R. Thorpe                                       thorpej@nas.nasa.gov
NASA Ames Research Center                            Home: +1 408 866 1912
NAS: M/S 258-5                                       Work: +1 650 604 0935
Moffett Field, CA 94035                             Pager: +1 650 940 5942