-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

On Feb 5, 2007, at 00:57, leon zadorin wrote:

> On 2/5/07, Michael Lorenz <macallan@netbsd.org> wrote:
>
>> Should be OF_interpret("line#", 0, 1, &crow); - nothing in, one out.
>>
>
> Ahh, cool - make sense to me now - thanks.
>
> In that case, what about the following code in "copy_rom_font" (same
> file, macppc/dev/ofb_cons.c):
>
> 	/* Get ROM FONT address. */
> 	OF_interpret("font-adr", 1, 1, &romfont);

Gah, another one I missed? Must be getting old :/

>> About the argument voodoo - we add one to both in and out because:
>> - - the command itself counts as first argument
>> - - OF returns some sort of status as first out
>
> ... and then, also (given that 1 in prepended to the number of args
> for command itself), in the "ofb_cnattach" (same file):
>
> /* move (rom monitor) cursor to the lowest line - 1 */
> 	OF_interpret("#lines 2 - to line#", 1, 0);

Right, that should be 0, 0.
I think I fixed most of them, did you update ofb_cons.c since last 
night?

have fun
Michael
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (Darwin)

iQEVAwUBRcck6cpnzkX8Yg2nAQLb2gf5AX8mrd6fUuA9y3mrTkn70IM3KEMFdspL
9/ZPBjB5HLcGLyvxPdXJRumeHpGmZpy8U8pO+WXImqwfNliO3+DC6dUEi/I7vbIS
Lx8VywAidNORLADAZUDaMBh85SOif0ogNHs6ucQb+6IbDlzdUWbviKmcKswm63qa
6HGMMKtAe3e9D1eVMelnKP52Ln9YFcgWHfiSwlHuMTTI+9bryH/KGvGdgZdQVAGV
WU85ziPXGxykJs9MI6T36mQ/hGxfjuj9yfGqDWlLiLtT4SLP/ybRn67URZ6UdtUw
sOVlza9fOXkoxbRrjdrhHSoCNv0Vh9M3Bu5Kh+Bnto8E/0Hl6Sjhzw==
=tO7G
-----END PGP SIGNATURE-----