Subject: Re: Re: Console drivers
To: Michael Lorenz <macallan@netbsd.org>
From: Marco Trillo <marcotrillo@gmail.com>
List: port-macppc
Date: 11/14/2006 23:15:50
------=_Part_65803_19630697.1163542550717
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi,

On 11/11/06, Marco Trillo <marcotrillo@gmail.com> wrote:
> But there is still a problem: although the monitor is set up
> correctly, the driver thinks it's still running at 640 x 480
> resolution mode, and so it creates a 640 x 480 display:
>
> radeonfb0: display 0: virtual resolution 640x480 at 32 bpp
> radeonfb0: port 0: physical 1024x768 89Hz
> radeonfb0: port 1: physical 1024x768 89Hz
>
> So it creates a small box of 640 x 480 pixels at the left edge of the
> screen, and the rest of the 1024 x 768 space is not used (it appears
> filled with a blue-ish color).

Well, I finally got it working ! (a patch is attached)

'radeonfb.c' has some checks to pickup a virtual resolution larger
than the physical resolution, so if there are multiple monitors
present, the smaller one will use panning.
But there were some places (like when the default videomode is
selected) when that check wasn't made.

I tried to fix this, a diff to the 'radeonfb.c' file is attached
(hopefully Gmail won't base64-encode the patch).

It works fine now for me ! Hope it doesn't break anything !

The relevant dmesg section with the new patch is:

radeonfb_pickres picked 640x480
radeonfb0: port 0: physical 1024x768 89Hz
radeonfb0: port 1: physical 1024x768 89Hz
radeonfb0: display 0: virtual resolution 1024x768 at 32 bpp

-- 

     -Marco

------=_Part_65803_19630697.1163542550717
Content-Type: text/plain; name=radeonfb.diff.txt; charset=ANSI_X3.4-1968
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="radeonfb.diff.txt"

SW5kZXg6IHJhZGVvbmZiLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2c3Jvb3Qvc3JjL3N5cy9k
ZXYvcGNpL3JhZGVvbmZiLmMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNgpkaWZmIC11IC1yMS42
IHJhZGVvbmZiLmMKLS0tIHJhZGVvbmZiLmMJNyBPY3QgMjAwNiAyMTozNjoxMiAtMDAwMAkxLjYK
KysrIHJhZGVvbmZiLmMJMTQgTm92IDIwMDYgMjE6MzY6MzQgLTAwMDAKQEAgLTcxNiwyMiArNzE2
LDM0IEBACiAJCS8qIGZvciB0ZXh0IG1vZGUsIHdlIHBpY2sgYSByZXNvbHV0aW9uIHRoYXQgd29u
J3QKIAkJICogcmVxdWlyZSBwYW5uaW5nICovCiAJCXJhZGVvbmZiX3BpY2tyZXMoZHAsICZkcC0+
cmRfdmlydHgsICZkcC0+cmRfdmlydHksIDApOwotCi0JCWFwcmludF9ub3JtYWwoIiVzOiBkaXNw
bGF5ICVkOiAiCi0JCSAgICAidmlydHVhbCByZXNvbHV0aW9uICVkeCVkIGF0ICVkIGJwcFxuIiwK
LQkJICAgIFhOQU1FKHNjKSwgaSwgZHAtPnJkX3ZpcnR4LCBkcC0+cmRfdmlydHksIGRwLT5yZF9i
cHApOworCQlEUFJJTlRGKCgicmFkZW9uZmJfcGlja3JlcyBwaWNrZWQgJWR4JWRcbiIsIGRwLT5y
ZF92aXJ0eCwKKwkJCQkgZHAtPnJkX3ZpcnR5KSk7CiAKIAkJLyogbm93IHNlbGVjdCB0aGUgKnZp
ZGVvIG1vZGUqIHRoYXQgd2Ugd2lsbCB1c2UgKi8KIAkJZm9yIChqID0gMDsgaiA8IGRwLT5yZF9u
Y3J0Y3M7IGorKykgewogCQkJY29uc3Qgc3RydWN0IHZpZGVvbW9kZSAqdm1wOwogCQkJdm1wID0g
cmFkZW9uZmJfcG9ydF9tb2RlKGRwLT5yZF9jcnRjc1tqXS5yY19wb3J0LAogCQkJICAgIGRwLT5y
ZF92aXJ0eCwgZHAtPnJkX3ZpcnR5KTsKKwkJCQorCQkJLyoKKwkJCSAqIG1ha2Ugc3VyZSB3ZSB1
c2UgdGhlIGxhcmdlc3QgdmlydHVhbCByZXNvbHV0aW9uLCAKKwkJCSAqIHRoZSBzbWFsbGVyIG1v
bml0b3Igd2lsbCBwYW4KKwkJCSAqLworCQkJaWYgKGRwLT5yZF92aXJ0eCA8IHZtcC0+aGRpc3Bs
YXkgfHwgCisJCQkgICAgZHAtPnJkX3ZpcnR5IDwgdm1wLT52ZGlzcGxheSkgeworCQkJICAgIGRw
LT5yZF92aXJ0eCA9IHZtcC0+aGRpc3BsYXk7CisJCQkgICAgZHAtPnJkX3ZpcnR5ID0gdm1wLT52
ZGlzcGxheTsKKwkJCX0KIAkJCWRwLT5yZF9jcnRjc1tqXS5yY192aWRlb21vZGUgPSAqdm1wOwog
CQkJcHJpbnRmKCIlczogcG9ydCAlZDogcGh5c2ljYWwgJWR4JWQgJWRIelxuIiwKIAkJCSAgICBY
TkFNRShzYyksIGosIHZtcC0+aGRpc3BsYXksIHZtcC0+dmRpc3BsYXksCiAJCQkgICAgRElWSURF
KERJVklERSh2bXAtPmRvdF9jbG9jayAqIDEwMDAsCiAJCQkJICAgICAgIHZtcC0+aHRvdGFsKSwg
dm1wLT52dG90YWwpKTsKIAkJfQorCQkKKwkJYXByaW50X25vcm1hbCgiJXM6IGRpc3BsYXkgJWQ6
ICIgCisgICAgICAgICAgICAgICAgICAgICJ2aXJ0dWFsIHJlc29sdXRpb24gJWR4JWQgYXQgJWQg
YnBwXG4iLCAKKyAgICAgICAgICAgICAgICAgICAgWE5BTUUoc2MpLCBpLCBkcC0+cmRfdmlydHgs
IGRwLT5yZF92aXJ0eSwgZHAtPnJkX2JwcCk7CiAKIAkJLyogTi5CLjogcmFkZW9uIHdhbnRzIDY0
LWJ5dGUgYWxpZ25lZCBzdHJpZGUgKi8KIAkJZHAtPnJkX3N0cmlkZSA9IGRwLT5yZF92aXJ0eCAq
IGRwLT5yZF9icHAgLyA4Owo=
------=_Part_65803_19630697.1163542550717--