Subject: Re: xconsole failed build
To: None <port-macppc@netbsd.org>
From: Christos Zoulas <christos@zoulas.com>
List: port-macppc
Date: 11/14/2004 05:32:58
In article <Pine.NEB.4.61.0411132308550.28500@phenotype.laffeycomputer.com>,
Joe Laffey <joe@laffeycomputer.com> wrote:
>On Sun, 14 Nov 2004, Christos Zoulas wrote:
>
>> In article <Pine.NEB.4.61.0411132104580.28500@phenotype.laffeycomputer.com>,
>> Joe Laffey <joe@laffeycomputer.com> wrote:
>>> I am getting a build failure when trying to build userland with the -x
>>> option to build.sh. I am building from sources checked out last night in
>>> the netbsd-2.0 tree.
>>
>> That is really unfortunate. We don't have 2.0 tag for xsrc so a recent
>> change I made to xconsole broke the 2.0 branch. We should bring up the
>> Makefile up-to-head in the xconsole directory or revert the change. I'd
>> rather do the first since the reason for the change is security related.
>
>Thanks for confirming this. Sorry it is something that needs fixing...
>
>So do you think the -lutil is all I need? (My build is not done yet.)

Yes, that's it. The code works fine with -lutil. In fact it should have
been fixed a long time, but nobody noticed. The real bug is that the
code allocated a pty without calling revoke(2).

christos